search

microsoft / AISkillsForWindows

Contains samples for implementing Windows Skills by extending the preview base API and using exsting skill packages
https://docs.microsoft.com/en-us/windows/ai/windows-vision-skills/
MIT License
166 stars 46 forks source link

User/t kazhua/galleryapp object detector #39

Closed t-kazhua closed 5 years ago

t-kazhua commented 5 years ago

Add Object Detector sample.

marianan commented 5 years ago 
    /// <param name="sender"></param>

Please fill the headers, we will open source this code. @Louis - do you have any recommendations for headers format, do we want to use tools like doxygen for documentation generation, I am not sure if we need to hand write the md file.... #Closed

Refers to: samples/GalleryApp/MainPage.xaml.cs:32 in 7b261e6. [](commit_id = 7b261e62b47c786afc97212dd88eb0ccbfbd211e, deletion_comment = False)

LPBourret commented 5 years ago 
    /// <param name="sender"></param>

using /// is ok. We write readme.md guides by hand. We don't need auto-generated xml doc for this code (i.e. since it is not a reusable .winmd) so it is really only to decorate this code for developer reading it directly. That said yes please make sure the comments are up to snuff and, in this case, that headers describe correctly each method. (line 20 can be corrected, "NavigateToObjectDetectorPage" needs comments)

In reply to: 505976422 [](ancestors = 505976422)

Refers to: samples/GalleryApp/MainPage.xaml.cs:32 in 7b261e6. [](commit_id = 7b261e62b47c786afc97212dd88eb0ccbfbd211e, deletion_comment = False)

LPBourret commented 5 years ago 
    private void NavigateToSkillPage(object sender, RoutedEventArgs e)

rename to something more representative or generalize accordingly #Resolved

Refers to: samples/GalleryApp/MainPage.xaml.cs:34 in 7b261e6. [](commit_id = 7b261e62b47c786afc97212dd88eb0ccbfbd211e, deletion_comment = False)