microsoft / AL-Go

The plug-and-play DevOps solution for Business Central app development on GitHub
MIT License
295 stars 125 forks source link

CI/CD Jobs failing on all projects starting last week at some point. #1052

Closed BMI-Mike closed 7 months ago

BMI-Mike commented 7 months ago
image

I'm getting the following error and warnings on several AL-Go projects starting at some point last week while out of the office. So far, it appears that only the CICD workflows are impacted. Other workflows such as UpdateGitHubGoSystemFiles work just fine.

I am assuming this is related to an AL-Go update since it impacted numerous projects within the same timeframe.

BMI-Mike commented 7 months ago

Appears similar to #1039

logs_23018261293.zip

In the Initialization / Complete Job step, I see the following warnings that are not easily seen in the logs.

Evaluate and set job outputs Set output 'telemetryScopeJson' Warning: Skip output 'environmentsMatrixJson' since it may contain secret. Set output 'environmentCount' Warning: Skip output 'deploymentEnvironmentsJson' since it may contain secret. Set output 'generateALDocArtifact' Set output 'deployALDocArtifact' Set output 'deliveryTargetsJson' Set output 'githubRunner' Set output 'githubRunnerShell' Set output 'projects' Warning: Skip output 'projectDependenciesJson' since it may contain secret. Warning: Skip output 'buildOrderJson' since it may contain secret. Set output 'workflowDepth' Cleaning up orphan processes

image
BMI-Mike commented 7 months ago

It appears that having any secret with "pretty" Azure credentials in GitHub, even secret names not used by AL-Go, will cause CICD to fail.

We recently added a secret related to other projects, and that is what broke CICD. Using the Troubleshooting workflow was a tremendous help to discover why this was happening. Our IT staff will follow up on the original #1039 issue.

freddydk commented 7 months ago

It appears that having any secret with "pretty" Azure credentials in GitHub, even secret names not used by AL-Go, will cause CICD to fail.

We recently added a secret related to other projects, and that is what broke CICD. Using the Troubleshooting workflow was a tremendous help to discover why this was happening. Our IT staff will follow up on the original #1039 issue.

In general, AL-Go projects should only have secrets available to them that they need/use - but yes, the way we retrieve secrets, we are subject to this problem.