microsoft / AL-Go

The plug-and-play DevOps solution for Business Central app development on GitHub
MIT License
253 stars 115 forks source link

Update logic for Increment Version Number #1108

Closed aholstrup1 closed 1 week ago

aholstrup1 commented 2 weeks ago

Problem If you define the repoVersion in .github/AL-Go-Settings.json it isn't updated when running the Increment Version Number workflow. In our case, the would like to keep the repoVersion the same across all Al-Go projects so having repoVersion defined on repo level makes sense for us (even if it is a project setting)

Proposed Solution

Fixes #1105

freddydk commented 2 weeks ago

Looking at the PR description:

According to the code - it looks like it is force created on the project level if it doesn't exist (which I think is correct) - meaning that the description is wrong, right?

On the last line - I don't think we are updating the repoversion on the repo level if it exists in all projects - do we?

aholstrup1 commented 2 weeks ago

Looking at the PR description:

  • if repoVersion is neither defined on project level or repo level, force create it on repo level
  • if projects is * then we update the repoVersion both on project level and repo level (if they already exist)

According to the code - it looks like it is force created on the project level if it doesn't exist (which I think is correct) - meaning that the description is wrong, right?

On the last line - I don't think we are updating the repoversion on the repo level if it exists in all projects - do we?

You're right :) The description was wrong. It should reflect the code now.