search

microsoft / AL-Go

The plug-and-play DevOps solution for Business Central app development on GitHub
MIT License
255 stars 115 forks source link

ContinuousDeployment = false is ignored in DeployToXXX #1133

Closed dksander closed 1 week ago

dksander commented 1 week ago

Hi, When I read the documentation for Basic Repo settings: https://github.com/microsoft/AL-Go/blob/main/Scenarios/settings.md#basic-repository-settings and specific the info about "DeployTo" "ContinuousDeployment = true if this environment should be used for continuous deployment, else false." I would expect that the following setup would continuous deploy to my TEST enviroment, while I would manuel have to deploy to the PROD enviroment: { "type": "PTE", "templateUrl": "https://github.com/microsoft/AL-Go-PTE@main", "DeployToPROD": { "EnvironmentType": "SaaS", "EnvironmentName": "Production", "Branches": [ "main" ], "SyncMode": "Add", "continuousDeployment": "false" }, "DeployToTEST": { "EnvironmentType": "SaaS", "EnvironmentName": "Sandbox", "Branches": [ "TESTING" ], "continuousDeployment": "true" } }

But that is not the case the, "continuousDeployment": "false" will act just link "continuousDeployment": "true", and the fix is not to include continuousDeployment tag.

I do not know if this is by design or an error, but if it is the case, then perhaps the documentation could be updated?

freddydk commented 1 week ago

The continuousDeployment property is a boolean - it looks like you specify it as a string. Remove the quotes, and it should work.

freddydk commented 1 week ago

BTW - the same applies to "true" - should be true.

dksander commented 1 week ago

Damn didn't catch that, but you are completely right. It was fixed when removed "