Closed pzentner closed 4 weeks ago
Looks like a bug. We did some changes to this area, which shouldn't have affected the functionality though. Do you have an AZURE_CREDENTIALS defined with access to a keyvault? Are you using the keyvault for secrets?
If you change to use microsoft/AL-Go-PTE@main -. I assume it works then?
I changed it to use microsoft/AL-Go-PTE@main and yes, it is working. I also have the AZURE_CREDENTIALS defined with access to a keyvault and am using the keyvault for secrets, but not for the environment secrets.
The reason for this issue is that this powershell command:
Get-AzKeyVaultSecret -VaultName "BuildVariables" -Name 'UAT-AUTHCONTEXT'
will return the secret if it exists or null if it doesn't, whereas this command
Get-AzKeyVaultSecret -VaultName "BuildVariables" -Name 'UAT_AUTHCONTEXT'
Will throw due to an illegal secret name.
GitHub secrets allows '_', but not '-' Azure DevOps keyvault allows '-', but not '_'
Therefore, we look for both, but it obviously shouldn't throw.
Shipped in preview
Using: AL-Go-Preview (current)
We have environments configured in GitHub (UAT, for instance) and have an environment secret "AUTHCONTEXT" created with the proper Json in there. However, when we run the CI/CD pipeline, it throws the following errors when trying to deploy the apps to the environment.
Did anything change in the way this is working or has to be defined? It used to work (not sure exactly when last).