search

microsoft / AL-Go

The plug-and-play DevOps solution for Business Central app development on GitHub
MIT License
295 stars 125 forks source link

Fix placeholder syntax in PR Handler action #1145

Closed cegekaJG closed 4 months ago

cegekaJG commented 4 months ago

This PR fixes an error introduced by #1130. The new reference values use the format() command to generate a git reference, but the placeholder syntax was incorrect. The two instances of ${0} per template have been replaced with {0}.

cegekaJG commented 4 months ago

Maybe also add a line in the release notes.

Do you mean a line explaining this PR in the "Issues"-section? I figured it wouldn't be necessary since this only fixes a change that is still only in the preview.

mazhelez commented 4 months ago

Maybe also add a line in the release notes.

Do you mean a line explaining this PR in the "Issues"-section? I figured it wouldn't be necessary since this only fixes a change that is still only in the preview.

Exactly because it is already shipped in preview. Repositories running on preview will get the There are updates for your AL-Go system, run 'Update AL-Go System Files' workflow to download the latest version of AL-Go. message and the release notes should explain what these changes are.

It's not a requirement, but a recommendation.