microsoft / AL-Go

The plug-and-play DevOps solution for Business Central app development on GitHub
MIT License
302 stars 125 forks source link

[Question]: Regarding warnings after update to 5.3 #1182

Open gntpet opened 3 months ago

gntpet commented 3 months ago

Question

After upgrade AL-GO to 5.3 we do received these warnings:

The property runs-on in DeployToPROD is expected to be of type Object[] image

Is it a code issue on your end or do we have to change something in our configs? My config looks like this:

"DeployToQA": {
    "EnvironmentType": "SaaS",
    "EnvironmentName": "QA",
    "Projects": "SRS.nl",
    "Branches": [
      "main"
    ],
    "ContinuousDeployment": true,
    "runs-on": "ubuntu-latest"
  },

Deployments works as expected

Best Regards, Gintautas

gntpet commented 2 months ago

Any input on this one, @freddydk ?

freddydk commented 2 months ago

Sorry, didn't see this. You should modify your "runs-on" to

"runs-on": [ "ubuntu-latest" ]

I will add this to documentation - it doesn't clearly state that runs-on should be an array. On github, it is clearly mentioned: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on - but you shouldn't need to read that.

gntpet commented 2 months ago

Thanks, it did help to remove the warning.

Nevertheless, there's an slight confusion about runs-on setting. Please check the image

image

freddydk commented 2 months ago

Both should be arrays as far as I know. Maybe the first isn't checked.

gntpet commented 2 months ago

Initially i set all of them to the type of object as per advise. But then pipeline could not run at all and gave this error: image

freddydk commented 2 months ago

wow - strange - will have a look.