[Bug]: includeDependencies not working as expected

microsoft / AL-Go

The plug-and-play DevOps solution for Business Central app development on GitHub

MIT License

286 stars 121 forks source link

[Bug]: includeDependencies not working as expected #1264

Open dsaveyn opened 6 days ago

dsaveyn commented 6 days ago

AL-Go version

6.0

Describe the issue

We have setup a project with the following settings:

"includeDependencies": [
  "Dynavision*.app",
  "ESC*.app"
]

But when we look at the release artifacts, the Continia artifacts are also included:

"includeDependencies": [
  "Dynavision*.app",
  "ESC*.app"
]

Expected behavior

The Continia artifacts should be taken from the AppSource Catalog

Steps to reproduce

Additional context (logs, screenshots, etc.)

logs_29638379195.zip

freddydk commented 4 days ago

IncludeDependencies is a property of the DeliverToAppSource setting (see https://aka.ms/algosettings#delivertoappsource) and only determines which apps are included when delivering to AppSource.

It looks like you are trying something different here?

Could you explain your scenario and what you are trying to achieve?

dsaveyn commented 4 days ago

Our app has 3 dependencies: a Dynavision app, an ESC app and the Continia Document Capture app. When we deliver the app to AppSource, the validation fails with the message that the Continia app files are not signed (no idea why exactly, I would expect them to be signed).

The AppSource submission contains 2 files: The main app file and a zip file containing the library apps: the Dynavision app, the ESC app and all Continia Document Capture apps. So for some reason the Continia Document Capture apps are still included in the library zip despite the filters specified in includeDependencies:

freddydk commented 4 days ago

Got it - will have a look.