microsoft / AL-Go

The plug-and-play DevOps solution for Business Central app development on GitHub
MIT License
303 stars 125 forks source link

Publish to AppSource fails in multi project repo #356

Closed jonaswre closed 1 year ago

jonaswre commented 1 year ago
Error: Deliver action failed. Error: AppSourceProductId needs to be specified in AppD/.AL-Go/settings.json in order to deliver to AppSource Stacktrace: at <ScriptBlock>, D:\a\_actions\microsoft\AL-Go-Actions\v2.3\Deliver\Deliver.ps1: line 418 at <ScriptBlock>, D:\a\_actions\microsoft\AL-Go-Actions\v2.3\Deliver\Deliver.ps1: line 98 at <ScriptBlock>, D:\a\_temp\6c84dd42-f6bd-4b08-bab2-b1ad63498722.ps1: line 2 at <ScriptBlock>, <No file>: line 1

This is the content of AppD/.AL-Go/settings.json

{
    "country": "de",
    "AppSourceCopMandatoryAffixes": [
       "TEST"
    ],
    "appFolders": [
        "app"
    ],
    "testFolders": [],
    "bcptTestFolders": [],
    "AppSourceProductId": "5f3a3117-d878-44b0-ad21-9986c8582cd9"
}

Its still based on the https://github.com/byndit/AL-Go-Issue138

P.S. obviously I deployed our product not that repo. The structure is just the same.

kb-dynaway commented 1 year ago

@freddydk To not create addtional thread. Is it possible to publish to AppSource multiple apps from the same repository? I have in one repo 8 apps that need to be published to AppSource.

Is it possible to have multiple AppSourceProductsIds?

jonaswre commented 1 year ago

@kb-dynaway

@freddydk anwsered this in https://github.com/microsoft/AL-Go/issues/328

freddydk commented 1 year ago

From v2.3 - yes but each AppSource product needs to be in a project by itself and the AppSourceProductId needs to be in the project settings file. But apparently there is another bug, which I have a fix for in a PR - when this makes it in, it will be added to preview

freddydk commented 1 year ago

This fix is now available in AL-Go preview

janlehmkuhl commented 1 year ago

Hi, I don't know if my problem is related to this customization, but we can't publish our AppSource app anymore, although all parameters are set as requested. Attached are the logs and two screenshots.

settings json errormsg logs_1613.zip

janlehmkuhl commented 1 year ago

image

janlehmkuhl commented 1 year ago

image Our CICD pipeline is also currently not working because it can no longer find the property for the AppSourceContinuousDelivery in AppSource. Although it is there.