search

microsoft / AL

Home of the Dynamics 365 Business Central AL Language extension for Visual Studio Code. Used to track issues regarding the latest version of the AL compiler and developer tools available in the Visual Studio Code Marketplace or as part of the AL Developer Preview builds for Dynamics 365 Business Central.
MIT License
744 stars 245 forks source link

Incorrectly referenced AS0011 from AppSourceCop #4610

Closed rdebath closed 5 years ago

rdebath commented 5 years ago

Describe the bug

Location of error is incorrect; pointing at a file that does not contain MS/AL code. (This appears to be the default location as noted in #4588) Error message itself is not correct (AIUI).

Fields are not part of the extension, this is moving existing fields.

To Reproduce

$ grep CreditTransferRegEntries */*                                                                                                                                                                        
src/Modification-Payment_Journal_Page_256.al:        moveafter(TransmitPayments;CreditTransferRegEntries)

$ grep Purch..FA */*                                                                                                                                                                                        
src/Modification-General_Posting_Setup_Page_314.al:        moveafter("Direct Cost Applied Account";"Purch. FA Disc. Account")                                                                             
src/Modification-General_Posting_Setup_Page_314.al:        moveafter("Purch. FA Disc. Account";"Purchase Variance Account")

$ grep Purchase.Variance  */*                                                                                                                                                                               
src/Modification-General_Posting_Setup_Page_314.al:        moveafter("Purch. FA Disc. Account";"Purchase Variance Account")

Expected behavior A clear and concise description of the error and it's location (if any).

Screenshots image

Versions: Name: AL Language Id: microsoft.al Description: AL development tools for Dynamics 365 Business Central Version: 2.1.86206 Publisher: Microsoft

JohanStenberg100 commented 5 years ago

Hi @rdebath, thanks for reporting this issue.

I can't reproduce this however, here's the example I use:

pageextension 50100 MyExtension extends "Payment Journal"
{
    layout
    {
    }

    actions
    {
        moveafter(TransmitPayments; CreditTransferRegEntries)
    }
}

Can you please post a small AL sample? I have activated CodeCop and AppSourceCop.

Thanks,

Johan

rdebath commented 5 years ago

Small repo with all the binaries uploaded to https://github.com/rdebath/ALHelloWorld

Name: AL Language Id: microsoft.al Description: AL development tools for Dynamics 365 Business Central Version: 2.1.91153 Publisher: Microsoft

qutreson commented 5 years ago

Hi @rdebath, this issue can still be reproduced with the latest extension from the marketplace but has been fixed in our master branch.