search

microsoft / AL

Home of the Dynamics 365 Business Central AL Language extension for Visual Studio Code. Used to track issues regarding the latest version of the AL compiler and developer tools available in the Visual Studio Code Marketplace or as part of the AL Developer Preview builds for Dynamics 365 Business Central.
MIT License
744 stars 245 forks source link

CodeCop - Record.GET arguments do not match the no. of primary key values #4622

Closed fvet closed 5 years ago

fvet commented 5 years ago

Is your feature request related to a problem? Please describe. In some scenario's, primary key definition might be changed (by adding / removing fields), resulting in review of code that fetches the record using the GET statement.

Describe the solution you'd like I would be interesting to have a CodeCop rule that warns (not errors) about GET statement where the number of arguments does not match the number of fields included in the primary key of the table referenced.

    var
        CountryTranslation: record "Country/Region Translation";
    begin
        CountryTranslation.GET('BE');  // Primary key consists of 2 fields, so this line should result in a warning
    end;
fvet commented 5 years ago

Please upvote on Experience Ideas https://experience.dynamics.com/ideas/idea/?ideaid=0e3cebdf-d36f-e911-80e7-0003ff68bfb9

fvet commented 5 years ago

One scenario that needs to be excluded is the Record.GET(Some_Var_Of_Type_RecordId)

atoader commented 5 years ago

@fvet thank you for posting this on the Ideas site as well. I will close this issue so that we can focus our attention in one place. For anybody interested in seeing this feature implemented, please vote on the idea.

dzzzb commented 3 years ago

One scenario that needs to be excluded is the Record.GET(Some_Var_Of_Type_RecordId)

This also needs to be documented... It is not at all: Record.Get([Any,...]) Method

The closest hint is this:

You cannot use the Get method to retrieve a record in a table by its primary key value if the primary key field in the table has the data type RecordID. In this case, you can retrieve the record by using the SetRange Method.

But it doesn't explain why one can't do that, namely because Get(RecordId) is overloaded to mean 'get the record whose PK forms this RecordId', not the expected 'get the record whose PK is a single field consisting of this RecordId'.

Good job I am having a quiet day, off to file at least one issue on https://github.com/MicrosoftDocs/dynamics365smb-docs/issues ... edit: actually, it's https://github.com/MicrosoftDocs/dynamics365smb-devitpro-pb/issues