search

microsoft / AL

Home of the Dynamics 365 Business Central AL Language extension for Visual Studio Code. Used to track issues regarding the latest version of the AL compiler and developer tools available in the Visual Studio Code Marketplace or as part of the AL Developer Preview builds for Dynamics 365 Business Central.
MIT License
730 stars 243 forks source link

CodeCop Rule: AA0100 Do not have identifiers with quotes in the name #5788

Closed RoieSantos closed 4 years ago

RoieSantos commented 4 years ago

Describe the bug We are currently updating our extension to BC16 in the ${CodeCop} declared under code analyzer it is showing multiple warnings. Below is one "AL0100 Do not have identifiers with quotes in the name"

To Reproduce Steps to reproduce the behavior:

  1. AL Language extension is installed (5.0.254558)
  2. Create a page extension of standard page "Customer Card" (21)
  3. Modify the existing field """Balance (LCY)"" - ABS(""Post Dated Checks (LCY)"")"
  4. A warning saying "Do not have identifiers with quotes in the name" will appear

Screenshots image

Standard Code BC16 image

Versions: AL Language 5.0.254558 Business Central : 16.0.11209.0 (Preview)

nicolassaleron commented 4 years ago

Well, even Microsoft is not yet compliant with their own rules :) If this warning annoys you, you can disable it in a ruleset file until Microsoft fix the control name.

https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-rule-set-syntax-for-code-analysis-tools

MarcHansenMicrosoft commented 4 years ago

It should be ok to refer to to something with a quote in. Warning should only appear on the actual definition.

MarcHansenMicrosoft commented 4 years ago

fixed in master