search

microsoft / AL

Home of the Dynamics 365 Business Central AL Language extension for Visual Studio Code. Used to track issues regarding the latest version of the AL compiler and developer tools available in the Visual Studio Code Marketplace or as part of the AL Developer Preview builds for Dynamics 365 Business Central.
MIT License
732 stars 243 forks source link

CaptionClass is unnecessarily triggered #6192

Open daansaveyn opened 3 years ago

daansaveyn commented 3 years ago

Describe the bug

The CaptionClass property of a Field is triggered unnecessarily when opening a random Page (even with a different Source Record). The issue only occurs if there's a Query object referring to the Table for which the Field exists.

P.S I hope this Bug can be handled here instead of re-submitting it via Collaborate since this clearly concerns an AL Developer Experience Bug. It's not clear anymore where to report what...

To Reproduce

NOTE: The issue also occurs when using the OnResolveCaptionClass event. (Also included in the sample)/

(See also Test Project in the attachments)

TestCaptionClass.zip

Expected behavior The CaptionClass property should not be evaluated in this case.

Screenshots Simulation CaptionClass

5. Versions:

image

kalberes commented 3 years ago

Unfortunately you will have to submit it through collaborate unless you can repro it with the latest vsix and latest BC server. Looks like a bug though.

This is our official answer: This GitHub repository is dedicated to handling issues and feedback for the latest Developer Preview releases of the AL development tools for Dynamics 365 Business Central.

If you can reproduce the problem on the latest Business Central Developer preview version we will be happy to look further into it. Otherwise please contact the regular support channel.

You can open Support Request to CSS through PartnerSource portal or contact your Service Account Manager (SAM) in the local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also step by step direct you how to open a support request or how to get credentials if this is the first time for you / your company.

For more details please read: https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/ https://github.com/Microsoft/AL/wiki/Frequently-Asked-Questions#i-found-an-issue-on-nav-2018-what-do-i-do

fvet commented 3 years ago

Issue has been logged on Collaborate.

https://partner.microsoft.com/en-us/dashboard/collaborate/engagements/1173/feedback/wits/Bugs/385419

dzzzb commented 3 years ago

~I tested the attached project but could not replicate the error message, on GB Business Central 16.5 (Platform 16.0.15884.17299 + Application 16.5.15897.16082)~

edit: looks like I did it wrong, as per @fvet's comment below

fvet commented 3 years ago

@dtkb I've tested the attached project (had to remove the 'Navitrans Core' from the dependend apps). Publishing on a BC 17.0.16974.0 shows NO errors. Fine, since the query 50100 "Parcel Query" object in the attached project is commented by default.

If you uncomment query 50100 "Parcel Query", and publish again, I get the unexpected 'This code should not be triggered' error on a BC 17.0.16974.0

Some background why this should be fixed:

dzzzb commented 3 years ago

@fvet D'oh, I don't think I had uncommented the Query. Silly me to assume a repro would be ready to reproduce ;-)

Agreed, this seems like a clear-cut bug; if captions are not to be shown on the current object being viewed/rendered, then caption classes should not be evaluated or called.

fvet commented 3 years ago

We're the one to blame. We should have prepared our repro project better the first time :)

daansaveyn commented 3 years ago

We're the one to blame. We should have prepared our repro project better the first time :)

@dtkb, @fvet

My apologies for the wasted time, I've overlooked this.