AA0214 - The record XXX should be modified before saving to the database (calling record method that updates fields).

[salgiza]

Describe the bug I think I've found an additional situation in which the AA0214 rule fails. I've got some code that gets a record, calls a method (defined in the table) that updates some fields, and then calls Modify() on the record. The AL analyzer complains that the record has not been modified before saving to the database.

To Reproduce Create a table with an integer field called TestField, and add a procedure that updates the field.

procedure UpdateField()
begin
    TestField := 1;
end;

Now create a procedure, that gets the record, and calls the method:

procedure TestAnalyzer()
var
    TestRecord: Record "Test Record";
begin
    if TestRecord.Get() then begin
        TestRecord.UpdateField();
        TestRecord.Modify();
    end;

(There is no need to actually run the code as this is an analyzer bug).

Expected behavior No warning should be raised.

Screenshots I'm including some screenshots of the real code where this warning was raised.

Note that the table method has all field assignments inside case statements, just in case I'm mistaken and the error is not so much due to the method being in the table as it is because of a combination of that and the field assignment being within a case statement.

5. Versions:

• AL Language: 6.1.381323
• Business Central: Platform 17.0.18204.18738 + Application 17.1.18256.18792

[mazhelez]

Thanks for reporting this issue. Sorry we haven’t completed it yet, but we’ve had to prioritize elsewhere. We’re planning to give the CodeCop engine and its rules an overhaul in a future major release. Thanks for your patience.

Going forward we will not track progress on CodeCop issues here on GitHub. Hence, we are closing this issue.