microsoft / AL

Home of the Dynamics 365 Business Central AL Language extension for Visual Studio Code. Used to track issues regarding the latest version of the AL compiler and developer tools available in the Visual Studio Code Marketplace or as part of the AL Developer Preview builds for Dynamics 365 Business Central.
MIT License
737 stars 243 forks source link

Run-AlValidation produces warning unrelated to Extension being validated #7152

Closed BW-PA closed 1 year ago

BW-PA commented 2 years ago

Describe the issue When running Run-AlValidation there is a warning output shown after compiling the extension as below

C:\ProgramData\BcContainerHelper\be303062-fac0-4094-8147-49eeb845071a\app.json(16,5): warning AL0667: 'Extension' is being deprecated in the versions: '4.0' or greater. The Extension compilation target is being deprecated. Use Cloud instead. This warning will become an error in a future release.

I managed to capture the app.json in question during the Run-AlValidation. It has all the key values from the extensions actual app.json but isn't a direct copy as it has additional fields that are not in the version of app.json I have in the repo used to create the .app file.

One of those additional fields is line 16 "target": "Extension",

I can't figure out where that entry is coming from. Does Run-AlValidation process generate the app.json itself?

Scripts used to create container and cause the issue

Run-AlValidation `
    -apps @("https://...preview/latest/apps.zip") `
    -affixes @("AAA") `
    -countries @("AU")

Additional context

At this stage I'm more just wondering if app.json is generated by Run-AlValidation. Can provide more detailed outputs if necessary, will attempt to recreate in a spike app.

freddydk commented 2 years ago

Yeah, so Run-AlValidation uses Extract-AppFileToFolder with -generateAppJson to generate the app.json file based on the NavxManifest.xml. My NavxManifest has target = cloud image hence my app.json gets: image The code transferring the value to app.json is straightforward: image No translation is going on. So, somehow this comes from your .app file - which must have target=extension - whether the compiler uses extension if your runtime or application has a specific version, I don't know.

BW-PA commented 2 years ago

OK, thanks for that. I've done some addtional testing with a Hello World app from AL: GO! I suspect what might be happening is that when app.json does not contain a value for "target" it gets added and given a default value of "extension".

I created a new app using AL: GO! and accepted all the defaults. App.json does not contain "target" entry (ms docs list it as optional). Compiling this app in VS Code gave the following message

Microsoft (R) AL Compiler version 9.4.10.7727
Copyright (C) Microsoft Corporation. All rights reserved

Compilation started for project 'TestAppJSONValidation' containing '1' files at '14:35:51.567'.

Compilation ended at '14:35:51.606'.

Success: The package is created.

When passing the app to Run-AlValidation the compile section shows the following warning

Microsoft (R) AL Compiler version 9.4.10.7727
Copyright (C) Microsoft Corporation. All rights reserved

C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(16,5): warning AL0667: 'Extension' is being deprecated in the versions: '4.0' or greater. The Extension compilation target 
is being deprecated. Use Cloud instead. This warning will become an error in a future release.
Compilation started for project 'TestAppJSONValidation' containing '1' files at '14:37:44.065'.

If I manually add a "target" entry to the app.json file with a value of "cloud" the error goes away during Run-AlValidation (which is expected). If I leave it empty or with a value equal to "target": "" then RunAlValidation raises the same AL0667 warning (though vs code compilation still succeeds with no warning shown).

Full output of Run-AlValidation follows.. Search for " warning AL0667" to see the warning I'm referring to.

PS C:\WINDOWS\system32> Run-AlValidation `
    -apps @("C:\Temp\Default publisher_TestAppJSONValidation_1.0.0.0.app") `
    -countries @("AU") `
    -validateCurrent
INFO: Windows 10 21H1/21H2 images are not yet available, using 2004 as these are found to work better than 20H2 on 21H1/21H2
  _____                               _                
 |  __ \                             | |               
 | |__) |_ _ _ __ __ _ _ __ ___   ___| |_ ___ _ __ ___ 
 |  ___/ _` | '__/ _` | '_ ` _ \ / _ \ __/ _ \ '__/ __|
 | |  | (_| | | | (_| | | | | | |  __/ |_  __/ |  \__ \
 |_|   \__,_|_|  \__,_|_| |_| |_|\___|\__\___|_|  |___/

Container name                  bcserver
Credential                      admin/Qamu8227
MemoryLimit                     8G
validateVersion                 
validateCurrent                 True
validateNextMinor               False
validateNextMajor               False
SasToken                        Not Specified
countries                       au
validateCountries               au
affixes                         
supportedCountries              
ObsoleteTagMinAllowedMajorMinor 
vsixFile                        
Install Apps
- None
Previous Apps
- None
Apps
- C:\Temp\Default publisher_TestAppJSONValidation_1.0.0.0.app

  _____       _ _ _                                          _        _                            
 |  __ \     | | (_)                                        (_)      (_)                           
 | |__) |   _| | |_ _ __   __ _    __ _  ___ _ __   ___ _ __ _  ___   _ _ __ ___   __ _  __ _  ___ 
 |  ___/ | | | | | | '_ \ / _` |  / _` |/ _ \ '_ \ / _ \ '__| |/ __| | | '_ ` _ \ / _` |/ _` |/ _ \
 | |   | |_| | | | | | | | (_| | | (_| |  __/ | | |  __/ |  | | (__  | | | | | | | (_| | (_| |  __/
 |_|    \__,_|_|_|_|_| |_|\__, |  \__, |\___|_| |_|\___|_|  |_|\___| |_|_| |_| |_|\__,_|\__, |\___|
                           __/ |   __/ |                                                 __/ |     
                          |___/   |___/                                                 |___/      

Pulling mcr.microsoft.com/businesscentral:10.0.19041.1415-filesonly

Pulling generic image took 0 seconds
  _____       _                      _                         _   _  __           _       
 |  __ \     | |                    (_)                       | | (_)/ _|         | |      
 | |  | | ___| |_ ___ _ __ _ __ ___  _ _ __   ___    __ _ _ __| |_ _| |_ __ _  ___| |_ ___ 
 | |  | |/ _ \ __/ _ \ '__| '_ ` _ \| | '_ \ / _ \  / _` | '__| __| |  _/ _` |/ __| __/ __|
 | |__| |  __/ |_  __/ |  | | | | | | | | | |  __/ | (_| | |  | |_| | || (_| | (__| |_\__ \
 |_____/ \___|\__\___|_|  |_| |_| |_|_|_| |_|\___|  \__,_|_|   \__|_|_| \__,_|\___|\__|___/

Found https://bcartifacts.azureedge.net/sandbox/20.4.44313.45632/au
Using https://bcartifacts.azureedge.net/sandbox/20.4.44313.45632/au

   _____                _   _                               _        _                 
  / ____|              | | (_)                             | |      (_)                
 | |     _ __ ___  __ _| |_ _ _ __   __ _    ___ ___  _ __ | |_ __ _ _ _ __   ___ _ __ 
 | |    | '__/ _ \/ _` | __| | '_ \ / _` |  / __/ _ \| '_ \| __/ _` | | '_ \ / _ \ '__|
 | |____| | |  __/ (_| | |_| | | | | (_| | | (__ (_) | | | | |_ (_| | | | | |  __/ |   
  \_____|_|  \___|\__,_|\__|_|_| |_|\__, |  \___\___/|_| |_|\__\__,_|_|_| |_|\___|_|   
                                     __/ |                                             
                                    |___/                                              

Creating container for country au
BcContainerHelper is version 3.0.12
BcContainerHelper is running as administrator
Hyper-V is Enabled
UsePsSession is True
Host is Microsoft Windows 10 Pro - 21H2
Docker Client Version is 20.10.17
Docker Server Version is 20.10.17
Removing Desktop shortcuts
Fetching all docker images
Fetching all docker volumes
Using image mcr.microsoft.com/businesscentral:10.0.19041.1415-filesonly
Creating Container bcserver
Style: sandbox
Multitenant: Yes
Version: 20.4.44313.45632
Platform: 20.0.44266.45589
Generic Tag: 1.0.2.13
Container OS Version: 10.0.19041.1415 (2004)
Host OS Version: 10.0.19044.1889 (21H2)
WARNING: Host OS is 21H1 and Container OS is 2004, defaulting to process isolation. If you experience problems, add -isolation hyperv.
Using process isolation
Using locale en-AU
Disabling the standard eventlog dump to container log every 2 seconds (use -dumpEventLog to enable)
Downloading C:\ProgramData\BcContainerHelper\Extensions\bcserver\Microsoft.VisualStudio.Services.VSIXPackage.vsix
Additional Parameters:
--env customNavSettings=EnableTaskScheduler=True
Files in C:\ProgramData\BcContainerHelper\Extensions\bcserver\my:
- AdditionalOutput.ps1
- MainLoop.ps1
- SetupVariables.ps1
- updatehosts.ps1
Creating container bcserver from image mcr.microsoft.com/businesscentral:10.0.19041.1415-filesonly
4fe8d117299b51594d1f7c53c45b560dbd9dd347bf8fea4b13f956fd96170787
Waiting for container bcserver to be ready
Using artifactUrl https://bcartifacts.azureedge.net/sandbox/20.4.44313.45632/au
Using installer from C:\Run\150-new
Installing Business Central
Installing from artifacts
Copying Service Tier Files
c:\dl\sandbox\20.4.44313.45632\platform\ServiceTier\Program Files
c:\dl\sandbox\20.4.44313.45632\platform\ServiceTier\System64Folder
Copying PowerShell Scripts
c:\dl\sandbox\20.4.44313.45632\platform\WindowsPowerShellScripts\Cloud\NAVAdministration
c:\dl\sandbox\20.4.44313.45632\platform\WindowsPowerShellScripts\WebSearch
Copying Web Client Files
c:\dl\sandbox\20.4.44313.45632\platform\WebClient\Microsoft Dynamics NAV
Copying Client Files
c:\dl\sandbox\20.4.44313.45632\platform\LegacyDlls\program files\Microsoft Dynamics NAV
c:\dl\sandbox\20.4.44313.45632\platform\LegacyDlls\program files\Microsoft Dynamics NAV
c:\dl\sandbox\20.4.44313.45632\platform\LegacyDlls\systemFolder
Copying ModernDev Files
c:\dl\sandbox\20.4.44313.45632\platform
c:\dl\sandbox\20.4.44313.45632\platform\ModernDev\program files\Microsoft Dynamics NAV
Copying additional files
Copying ConfigurationPackages
C:\dl\sandbox\20.4.44313.45632\au\ConfigurationPackages
Copying Test Assemblies
C:\dl\sandbox\20.4.44313.45632\platform\Test Assemblies
Copying Extensions
C:\dl\sandbox\20.4.44313.45632\au\Extensions
Copying Applications
C:\dl\sandbox\20.4.44313.45632\platform\Applications
Copying Applications.AU
C:\dl\sandbox\20.4.44313.45632\au\Applications.AU
Copying dependencies
Copying ReportBuilder
Importing PowerShell Modules
Skipping restore of Cronus database
Modifying Business Central Service Tier Config File for Docker
Installing SIP crypto provider: 'C:\Windows\System32\NavSip.dll'
Installation took 21 seconds
Installation complete
Ready for connections!
Reading CustomSettings.config from bcserver

Creating container took 46 seconds
  _____                   _                                    _____                           _____            
 |  __ \                 (_)                 /\               / ____|                         / ____|           
 | |__) |   _ _ __  _ __  _ _ __   __ _     /  \   _ __  _ __| (___   ___  _   _ _ __ ___ ___| |     ___  _ __  
 |  _  / | | | '_ \| '_ \| | '_ \ / _` |   / /\ \ | '_ \| '_ \\___ \ / _ \| | | | '__/ __/ _ \ |    / _ \| '_ \ 
 | | \ \ |_| | | | | | | | | | | | (_| |  / ____ \| |_) | |_) |___) | (_) | |_| | | | (__  __/ |____ (_) | |_) |
 |_|  \_\__,_|_| |_|_| |_|_|_| |_|\__, | /_/    \_\ .__/| .__/_____/ \___/ \__,_|_|  \___\___|\_____\___/| .__/ 
                                   __/ |          | |   | |                                              | |    
                                  |___/           |_|   |_|                                              |_|    
Default publisher_TestAppJSONValidation_1.0.0.0.app is not signed, result is NotSigned
Extracting C:\ProgramData\BcContainerHelper\1b391896-d36a-4f57-9191-8d96151bc66e\Default publisher_TestAppJSONValidation_1.0.0.0.app
Analyzing: Default publisher_TestAppJSONValidation_1.0.0.0.app
Using affixes: 
Downloading C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\appsource.default.ruleset.json
AppSourceCop.json content:
{
    "mandatoryAffixes":  [

                         ]
}
Ruleset.json content:
{
    "name":  "Run-AlCops RuleSet",
    "description":  "Generated by Run-AlCops",
    "includedRuleSets":  [
                             {
                                 "path":  "C:\\ProgramData\\BcContainerHelper\\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\\appsource.default.ruleset.json",
                                 "action":  "Default"
                             }
                         ]
}
Using Symbols Folder: C:\ProgramData\BcContainerHelper\6c7d35b3-6d4e-4f8e-8264-483fc6af859e
Copying System.app from Container
Copying Microsoft_AMC Banking 365 Fundamentals_20.4.44313.45632.app from Container
Copying Microsoft_Any_20.4.44313.45632.app from Container
Copying Microsoft_Application_20.4.44313.45632.app from Container
Copying Microsoft_Base Application_20.4.44313.45632.app from Container
Copying Microsoft_Basic Experience_20.4.44313.45632.app from Container
Copying Microsoft_Business Central Cloud Migration - Previous Release (AU)_20.4.44313.45632.app from Container
Copying Microsoft_Business Central Cloud Migration - Previous Release_20.4.44313.45632.app from Container
Copying Microsoft_Business Central Cloud Migration API_20.4.44313.45632.app from Container
Copying Microsoft_Business Central Intelligent Cloud_20.4.44313.45632.app from Container
Copying Microsoft_Company Hub_20.4.44313.45632.app from Container
Copying Microsoft_Contoso Coffee Demo Dataset (AU)_20.4.44313.45632.app from Container
Copying Microsoft_Contoso Coffee Demo Dataset_20.4.44313.45632.app from Container
Copying Microsoft_Czech language (Czechia)_20.4.44313.45632.app from Container
Copying Microsoft_Danish language (Denmark)_20.4.44313.45632.app from Container
Copying Microsoft_Data Archive_20.4.44313.45632.app from Container
Copying Microsoft_Dutch language (Belgium)_20.4.44313.45632.app from Container
Copying Microsoft_Dutch language (Netherlands)_20.4.44313.45632.app from Container
Copying Microsoft_Dynamics GP History SmartLists_20.4.44313.45632.app from Container
Copying Microsoft_Dynamics GP Intelligent Cloud_20.4.44313.45632.app from Container
Copying Microsoft_Email - Current User Connector_20.4.44313.45632.app from Container
Copying Microsoft_Email - Microsoft 365 Connector_20.4.44313.45632.app from Container
Copying Microsoft_Email - Outlook REST API_20.4.44313.45632.app from Container
Copying Microsoft_Email - SMTP API_20.4.44313.45632.app from Container
Copying Microsoft_Email - SMTP Connector_20.4.44313.45632.app from Container
Copying Microsoft_English language (Australia)_20.4.44313.45632.app from Container
Copying Microsoft_English language (Canada)_20.4.44313.45632.app from Container
Copying Microsoft_English language (New Zealand)_20.4.44313.45632.app from Container
Copying Microsoft_English language (United Kingdom)_20.4.44313.45632.app from Container
Copying Microsoft_English language (United States)_20.4.44313.45632.app from Container
Copying Microsoft_Essential Business Headlines_20.4.44313.45632.app from Container
Copying Microsoft_Finnish language (Finland)_20.4.44313.45632.app from Container
Copying Microsoft_French language (Belgium)_20.4.44313.45632.app from Container
Copying Microsoft_French language (Canada)_20.4.44313.45632.app from Container
Copying Microsoft_French language (France)_20.4.44313.45632.app from Container
Copying Microsoft_French language (Switzerland)_20.4.44313.45632.app from Container
Copying Microsoft_German language (Austria)_20.4.44313.45632.app from Container
Copying Microsoft_German language (Germany)_20.4.44313.45632.app from Container
Copying Microsoft_German language (Switzerland)_20.4.44313.45632.app from Container
Copying Microsoft_Icelandic language (Iceland)_20.4.44313.45632.app from Container
Copying Microsoft_Image Analyzer_20.4.44313.45632.app from Container
Copying Microsoft_Intelligent Cloud Base_20.4.44313.45632.app from Container
Copying Microsoft_Italian language (Italy)_20.4.44313.45632.app from Container
Copying Microsoft_Italian language (Switzerland)_20.4.44313.45632.app from Container
Copying Microsoft_Late Payment Prediction_20.4.44313.45632.app from Container
Copying Microsoft_Library Assert_20.4.44313.45632.app from Container
Copying Microsoft_Library Variable Storage_20.4.44313.45632.app from Container
Copying Microsoft_Microsoft Pay Payments_20.4.44313.45632.app from Container
Copying Microsoft_Norwegian language (Norway)_20.4.44313.45632.app from Container
Copying Microsoft_Payment Links to PayPal_20.4.44313.45632.app from Container
Copying Microsoft_Performance Toolkit_20.4.44313.45632.app from Container
Copying Microsoft_Permissions Mock_20.4.44313.45632.app from Container
Copying Microsoft_Recommended Apps_20.4.44313.45632.app from Container
Copying Microsoft_Russian language (Russia)_20.4.44313.45632.app from Container
Copying Microsoft_Sales and Inventory Forecast_20.4.44313.45632.app from Container
Copying Microsoft_Send remittance advice by email_20.4.44313.45632.app from Container
Copying Microsoft_Send To Email Printer_20.4.44313.45632.app from Container
Copying Microsoft_Shopify Connector_20.4.44313.45632.app from Container
Copying Microsoft_Simplified Bank Statement Import_20.4.44313.45632.app from Container
Copying Microsoft_Spanish language (Mexico)_20.4.44313.45632.app from Container
Copying Microsoft_Spanish language (Spain)_20.4.44313.45632.app from Container
Copying Microsoft_Swedish language (Sweden)_20.4.44313.45632.app from Container
Copying Microsoft_System Application_20.4.44313.45632.app from Container
Copying Microsoft_Test Runner_20.4.44313.45632.app from Container
Copying Microsoft_Troubleshoot FA Ledger Entries_20.4.44313.45632.app from Container
Copying Microsoft_Universal Print Integration_20.4.44313.45632.app from Container
Copying Microsoft_WorldPay Payments Standard_20.4.44313.45632.app from Container
Copying Microsoft__Exclude_AnonymizedDataSharing__20.4.44313.45632.app from Container
Copying Microsoft__Exclude_APIV1__20.4.44313.45632.app from Container
Copying Microsoft__Exclude_APIV2__20.4.44313.45632.app from Container
Copying Microsoft__Exclude_Bank Deposits_20.4.44313.45632.app from Container
Copying Microsoft__Exclude_ClientAddIns__20.4.44313.45632.app from Container
Copying Microsoft__Exclude_Email Logging Using Graph API_20.4.44313.45632.app from Container
Copying Microsoft__Exclude_Microsoft Dynamics 365 - SmartList_20.4.44313.45632.app from Container
Copying Microsoft__Exclude_PlanConfiguration__20.4.44313.45632.app from Container
Copying Microsoft__Exclude_ReportLayouts_20.4.44313.45632.app from Container
Copying Microsoft__Exclude_SyncBaseApp__20.4.44313.45632.app from Container
INFO: You have to specify AuthContext and Environment if you are compiling in a filesOnly container in order to download dependencies
Compiling...
.\alc.exe /project:"C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375" /packagecachepath:"C:\ProgramData\BcContainerHelper\6c7d35b3-6d4e-4f8e-8264-483fc6af859e" /out:"C:\ProgramData\
BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\Default publisher_TestAppJSONValidation_1.0.0.0.app" /GenerateReportLayout- /analyzer:C:\build\vsix\extension\bin\Analyzers\Microsoft.Dynamics.Nav.
AppSourceCop.dll /ruleset:C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\ruleset.json /reportsuppresseddiagnostics /assemblyprobingpaths:"C:\Program Files (x86)\Microsoft Dynamics
 NAV\200\RoleTailored Client","C:\Program Files\Microsoft Dynamics NAV\200\Service","C:\Program Files (x86)\Open XML SDK\V2.5\lib","c:\Windows\Microsoft.NET\Assembly","C:\Test Assemblies\Mock Assemblies
"
Microsoft (R) AL Compiler version 9.4.10.7727
Copyright (C) Microsoft Corporation. All rights reserved

C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(16,5): warning AL0667: 'Extension' is being deprecated in the versions: '4.0' or greater. The Extension compilation target 
is being deprecated. Use Cloud instead. This warning will become an error in a future release.
Compilation started for project 'TestAppJSONValidation' containing '1' files at '14:37:44.065'.

C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(1,1): warning AS0092: The app.json file must specify an Azure Application Insights resource with the property 'applicationI
nsightsConnectionString' for monitoring operations related to this extension. See https://docs.microsoft.com/dynamics365/business-central/dev-itpro/administration/telemetry-overview for additional infor
mation.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(6,5): error AS0051: The manifest property 'brief' must be specified and contain a meaningful value.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(7,5): error AS0051: The manifest property 'description' must be specified and contain a meaningful value.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(14,5): error AS0051: The manifest property 'privacyStatement' must be specified and contain a meaningful value.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(13,5): error AS0051: The manifest property 'EULA' must be specified and contain a meaningful value.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(15,5): error AS0051: The manifest property 'help' must be specified and contain a meaningful value.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(11,5): error AS0051: The manifest property 'logo' must be specified and contain a meaningful value.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(1,1): error AS0051: The manifest property 'contextSensitiveHelpUrl' must be specified and contain a meaningful value.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(23,5): error AS0084: The ID range '[50100..50149]' is not valid. It must be within the range allocated to the partner for A
ppSource, within the range '[1000000..75999999]' allocated to AppSource applications, and outside the range '[50000..99999]' allocated to per-tenant customizations.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(29,5): error AS0015: The "TranslationFile" flag must be added to the "features" array in the app.json file.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\app.json(12,5): error AS0052: The property 'url' must be set to a valid URL.
C:\ProgramData\BcContainerHelper\b5bfbe2e-6a47-4587-9a80-eb3ea06f2375\AppSourceCop.json(1,1): error AS0054: The AppSourceCop configuration must specify one of the following properties: 'mandatorySuffix'
, 'mandatoryPrefix', or 'mandatoryAffixes'

Compilation ended at '14:37:50.208'.

App generation failed with exit code 1
Compile-AppInBcContainer Telemetry Correlation Id: a60547da-530a-4d99-a03d-03979b3f5a66
ERROR App generation failed with exit code 1
Ignoring warnings
Ignoring infos
Copy C:\ProgramData\BcContainerHelper\1b391896-d36a-4f57-9191-8d96151bc66e\Default publisher_TestAppJSONValidation_1.0.0.0.app to C:\ProgramData\BcContainerHelper\6c7d35b3-6d4e-4f8e-8264-483fc6af859e

Running AppSourceCop took 30 seconds

  _____                           _                _____            _        _                 
 |  __ \                         (_)              / ____|          | |      (_)                
 | |__) |___ _ __ ___   _____   ___ _ __   __ _  | |     ___  _ __ | |_ __ _ _ _ __   ___ _ __ 
 |  _  // _ \ '_ ` _ \ / _ \ \ / / | '_ \ / _` | | |    / _ \| '_ \| __/ _` | | '_ \ / _ \ '__|
 | | \ \  __/ | | | | | (_) \ V /| | | | | (_| | | |____ (_) | | | | |_ (_| | | | | |  __/ |   
 |_|  \_\___|_| |_| |_|\___/ \_/ |_|_| |_|\__, |  \_____\___/|_| |_|\__\__,_|_|_| |_|\___|_|   
                                           __/ |                                               
                                          |___/                                                

Removing Session bcserver
Removing container bcserver
Removing entries from hosts
Removing bcserver from container hosts file
Removing bcserver-* from container hosts file
Removing Desktop shortcuts
Removing C:\ProgramData\BcContainerHelper\Extensions\bcserver

Removing container took 2 seconds

AL Validation finished in 246 seconds
 __      __   _ _     _       _   _               _____                _ _       
 \ \    / /  | (_)   | |     | | (_)             |  __ \              | | |      
  \ \  / /_ _| |_  __| | __ _| |_ _  ___  _ __   | |__) |___ ___ _   _| | |_ ___ 
   \ \/ / _` | | |/ _` |/ _` | __| |/ _ \| '_ \  |  _  // _ \ __| | | | | __/ __|
    \  / (_| | | | (_| | (_| | |_| | (_) | | | | | | \ \  __\__ \ |_| | | |_\__ \
     \/ \__,_|_|_|\__,_|\__,_|\__|_|\___/|_| |_| |_|  \_\___|___/\__,_|_|\__|___/

13 errors found in Default publisher_TestAppJSONValidation_1.0.0.0.app on https://bcartifacts.azureedge.net/sandbox/20.4.44313.45632/au:
Default publisher_TestAppJSONValidation_1.0.0.0.app is not signed, result is NotSigned
app.json(6,5): error AS0051: The manifest property 'brief' must be specified and contain a meaningful value.
app.json(7,5): error AS0051: The manifest property 'description' must be specified and contain a meaningful value.
app.json(14,5): error AS0051: The manifest property 'privacyStatement' must be specified and contain a meaningful value.
app.json(13,5): error AS0051: The manifest property 'EULA' must be specified and contain a meaningful value.
app.json(15,5): error AS0051: The manifest property 'help' must be specified and contain a meaningful value.
app.json(11,5): error AS0051: The manifest property 'logo' must be specified and contain a meaningful value.
app.json(1,1): error AS0051: The manifest property 'contextSensitiveHelpUrl' must be specified and contain a meaningful value.
app.json(23,5): error AS0084: The ID range '[50100..50149]' is not valid. It must be within the range allocated to the partner for AppSource, within the range '[1000000..75999999]' allocated to AppSourc
e applications, and outside the range '[50000..99999]' allocated to per-tenant customizations.
app.json(29,5): error AS0015: The "TranslationFile" flag must be added to the "features" array in the app.json file.
app.json(12,5): error AS0052: The property 'url' must be set to a valid URL.
AppSourceCop.json(1,1): error AS0054: The AppSourceCop configuration must specify one of the following properties: 'mandatorySuffix', 'mandatoryPrefix', or 'mandatoryAffixes'
App generation failed with exit code 1

  _____                          ___      __   _ _     _       _   _               ______    _ _                
 |  __ \                   /\   | \ \    / /  | (_)   | |     | | (_)             |  ____|  (_) |               
 | |__) |   _ _ __ ______ /  \  | |\ \  / /_ _| |_  __| | __ _| |_ _  ___  _ __   | |__ __ _ _| |_   _ _ __ ___ 
 |  _  / | | | '_ \______/ /\ \ | | \ \/ / _` | | |/ _` |/ _` | __| |/ _ \| '_ \  |  __/ _` | | | | | | '__/ _ \
 | | \ \ |_| | | | |    / ____ \| |  \  / (_| | | | (_| | (_| | |_| | (_) | | | | | | | (_| | | | |_| | | |  __/
 |_|  \_\__,_|_| |_|   /_/    \_\_|   \/ \__,_|_|_|\__,_|\__,_|\__|_|\___/|_| |_| |_|  \__,_|_|_|\__,_|_|  \___|

13 errors found in Default publisher_TestAppJSONValidation_1.0.0.0.app on https://bcartifacts.azureedge.net/sandbox/20.4.44313.45632/au:
Default publisher_TestAppJSONValidation_1.0.0.0.app is not signed, result is NotSigned
app.json(6,5): error AS0051: The manifest property 'brief' must be specified and contain a meaningful value.
app.json(7,5): error AS0051: The manifest property 'description' must be specified and contain a meaningful value.
app.json(14,5): error AS0051: The manifest property 'privacyStatement' must be specified and contain a meaningful value.
app.json(13,5): error AS0051: The manifest property 'EULA' must be specified and contain a meaningful value.
app.json(15,5): error AS0051: The manifest property 'help' must be specified and contain a meaningful value.
app.json(11,5): error AS0051: The manifest property 'logo' must be specified and contain a meaningful value.
app.json(1,1): error AS0051: The manifest property 'contextSensitiveHelpUrl' must be specified and contain a meaningful value.
app.json(23,5): error AS0084: The ID range '[50100..50149]' is not valid. It must be within the range allocated to the partner for AppSource, within the range '[1000000..75999999]' allocated to AppSourc
e applications, and outside the range '[50000..99999]' allocated to per-tenant customizations.
app.json(29,5): error AS0015: The "TranslationFile" flag must be added to the "features" array in the app.json file.
app.json(12,5): error AS0052: The property 'url' must be set to a valid URL.
AppSourceCop.json(1,1): error AS0054: The AppSourceCop configuration must specify one of the following properties: 'mandatorySuffix', 'mandatoryPrefix', or 'mandatoryAffixes'
App generation failed with exit code 1

PS C:\WINDOWS\system32> 
freddydk commented 2 years ago

I can confirm that I can repro this. image

Will report to the ModernDev team - I think that is their bug.

SBalslev commented 2 years ago

Please report on microsoft/AL and we'll take care of it :)

BW-PA commented 1 year ago

Thanks @JesperSchulz 🙏🏻