search

microsoft / AL

Home of the Dynamics 365 Business Central AL Language extension for Visual Studio Code. Used to track issues regarding the latest version of the AL compiler and developer tools available in the Visual Studio Code Marketplace or as part of the AL Developer Preview builds for Dynamics 365 Business Central.
MIT License
718 stars 242 forks source link

AA0248 Add 'this' qualification. - Missing Runtime version check #7742

Open pri-kise opened 1 month ago

pri-kise commented 1 month ago

Please include the following with each issue:

1. Describe the bug The CodeCop should check for the runtime specified in the app.json and only trigger the warning AA0248 then.

2. To Reproduce Steps to reproduce the behavior:

    procedure SaveContactSync(CurrUserSecurityID: Guid; var Contact: Record Contact; NewID: Text)
    var
        RecordRef: RecordRef;
    begin
        RecordRef.GetTable(Contact);
        SaveSync(CurrUserSecurityID, RecordRef, Enum::"PTE Entity"::Contact, NewID); // Wrong warning for this
    end;

    procedure SaveSync(CurrUserSecurityID: Guid; var RecordRef: RecordRef; MgEntity: Enum "PTE Entity"; NewID: Text)
    var

    begin
        // Magic
    end;

.

3. Expected behavior Similiar to other properties the CodeCop should respect the runtime version.

4. Actual behavior The runtime is ignored.

5. Versions:

Internal work item: AB#534070