search

microsoft / AL

Home of the Dynamics 365 Business Central AL Language extension for Visual Studio Code. Used to track issues regarding the latest version of the AL compiler and developer tools available in the Visual Studio Code Marketplace or as part of the AL Developer Preview builds for Dynamics 365 Business Central.
MIT License
722 stars 242 forks source link

Rule AA0234 implemented inconsistently? #7787

Open NKarolak opened 1 week ago

NKarolak commented 1 week ago

Please include the following with each issue:

1. Describe the bug Rule AA0234 is not activated the way we know it from other rules, inconsistently. Bug or feature for all new rules to come?

2. To Reproduce By default, rule AA0234 is set to action Warning, as we can see in the docs, and in the AZ AL DevTools Code Analyzers view: image

This usually means, that this rule is active. But it isn't. Steps to reproduce the behavior:

  1. In your app without any tooltips on table label fields, update your app.json to runtime 13.0. No warning AA0234.
  2. Add the rule to your project ruleset file. Only after that, warnings AA0234 appear as expected.

I know that this is by design as per docs: image But when you instruct to "enable the rule", I'd assume to find it first in disabled state - not in state "Warning", but for some weird reasons not working :-/

3. Expected behavior The rule should be simply action = Hidden by default.

4. Actual behavior The rule is Warning by default, but is in fact not active until we add it to a ruleset. I don't understand why it was solved that way.

5. Versions:

thpeder commented 6 days ago

Hi @NKarolak,

Thanks for the issue. We will make sure it is aligned with the other rules