[Event Request] Codeunit 6500 - Procedure RetrieveInvoiceSpecification

rvillanueva360 commented 2 years ago

Reason: Need the event to support extensibility of RetrieveInvoiceSpecification function for the codeunit 6500: Item Tracking Management on upgrade project in BC Cloud Tenant.

Sample code:

procedure RetrieveInvoiceSpecification(SourceSpecification: Record "Tracking Specification"; var TempInvoicingSpecification: Record "Tracking Specification" temporary) OK: Boolean
var
    TrackingSpecification: Record "Tracking Specification";
    ReservEntry: Record "Reservation Entry";
    TempTrackingSpecSummedUp: Record "Tracking Specification" temporary;
    IsHandled: Boolean;
begin
    OK := false;
    TempInvoicingSpecification.Reset();
    TempInvoicingSpecification.DeleteAll();
    ReservEntry.SetSourceFilter(
      SourceSpecification."Source Type", SourceSpecification."Source Subtype", SourceSpecification."Source ID",
      SourceSpecification."Source Ref. No.", true);
    ReservEntry.SetSourceFilter(SourceSpecification."Source Batch Name", SourceSpecification."Source Prod. Order Line");
    ReservEntry.SetFilter("Reservation Status", '<>%1', ReservEntry."Reservation Status"::Prospect);
    ReservEntry.SetFilter("Item Tracking", '<>%1', ReservEntry."Item Tracking"::None);
    SumUpItemTracking(ReservEntry, TempTrackingSpecSummedUp, false, true);
    // TrackingSpecification contains information about lines that should be invoiced:
    TrackingSpecification.SetSourceFilter(
      SourceSpecification."Source Type", SourceSpecification."Source Subtype", SourceSpecification."Source ID",
      SourceSpecification."Source Ref. No.", true);
    TrackingSpecification.SetSourceFilter(
      SourceSpecification."Source Batch Name", SourceSpecification."Source Prod. Order Line");

    //EVENT REQUEST 
    IsHandled := false; 
    OnBeforeFindTrackingSpecification(TempInvoicingSpecification, TempTrackingSpecSummedUp, TrackingSpecification, SourceSpecification, OK, IsHandled); 
    if not IsHandled then
    //EVENT REQUEST
        if TrackingSpecification.FindSet() then
            repeat
                TrackingSpecification.TestField("Qty. to Handle (Base)", 0);
                TrackingSpecification.TestField("Qty. to Handle", 0);
                if not TrackingSpecification.Correction then begin
                    TempInvoicingSpecification := TrackingSpecification;
                    TempInvoicingSpecification."Qty. to Invoice" :=
                    Round(TempInvoicingSpecification."Qty. to Invoice (Base)" /
                        SourceSpecification."Qty. per Unit of Measure", UOMMgt.QtyRndPrecision);
                    TempInvoicingSpecification.Insert();
                    OK := true;
                    TempTrackingSpecSummedUp.SetTrackingFilterFromSpec(TempInvoicingSpecification);
                    if TempTrackingSpecSummedUp.FindFirst() then begin
                        TempTrackingSpecSummedUp."Qty. to Invoice (Base)" += TempInvoicingSpecification."Qty. to Invoice (Base)";
                        OnBeforeTempTrackingSpecSummedUpModify(TempTrackingSpecSummedUp, TempInvoicingSpecification);
                        TempTrackingSpecSummedUp.Modify();
                    end else begin
                        TempTrackingSpecSummedUp := TempInvoicingSpecification;
                        TempTrackingSpecSummedUp.Insert();
                    end;
                end;
            until TrackingSpecification.Next() = 0;

    if not IsConsume and (SourceSpecification."Qty. to Invoice (Base)" <> 0) then
        CheckQtyToInvoiceMatchItemTracking(
          TempTrackingSpecSummedUp, TempInvoicingSpecification,
          SourceSpecification."Qty. to Invoice (Base)", SourceSpecification."Qty. per Unit of Measure");
    TempInvoicingSpecification.SetFilter("Qty. to Invoice (Base)", '<>0');
    if not TempInvoicingSpecification.FindFirst() then
        TempInvoicingSpecification.Init();
end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeFindTrackingSpecification(var TempInvoicingSpecification: Record "Tracking Specification"; var TempTrackingSpecSummedUp: Record "Tracking Specification" temporary; TrackingSpecification: Record "Tracking Specification"; SourceSpecification: Record "Tracking Specification"; var OK: Boolean; var IsHandled: Boolean)
    begin
    end;

rvillanueva360 commented 2 years ago

Do we have an idea about timelines and how to expedite this request because it is holding up a client upgrade, we need to inform the stake holders.

rvillanueva360 commented 2 years ago

May I follow up on timelines to expedite this request because it is holding up client upgrade, we need to report update the stake holders.

rvillanueva360 commented 2 years ago

May I follow up again about timelines and how to expedite this request because it is holding up a client upgrade, we need to inform the stake holders.

AlexanderYakunin commented 2 years ago

Please explain why do you need this for upgrade project? In which version you expect us to implement this event?

JesperSchulz commented 2 years ago

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 48534.

rvillanueva360 commented 2 years ago

Thanks. Please let us know when we can test.

rvillanueva360 commented 1 year ago

Still not found in BC 21.1. Please let us know which build will have this event.

JesperSchulz commented 1 year ago

I can see the changes in the 22 release:

I cannot find them in 21.x yet. @AlexanderYakunin, do you have an update on when this event is going to get backported?

rvillanueva360 commented 1 year ago

Hi Jesper,

Is there a way to expedite these event requests on BC21.x? https://github.com/microsoft/ALAppExtensions/issues/20511 https://github.com/microsoft/ALAppExtensions/issues/20512

It is holding up our upgrade project.

Cheers,

[360 Visibility]https://www.360visibility.com/?utm_source=email-signature Randy Villanueva Sr. Dynamics Consultant @.**@.> | (905) 907-3610<tel:(905)%20907-3610> 926 Nashville Rd., Vaughan ON L0J 1C0 [Twitter]https://twitter.com/360visibility[LinkedIn]https://www.linkedin.com/company/360-visibility[YouTube]https://www.youtube.com/user/360visibilityinc[Facebook]https://www.facebook.com/360Vis/[Instagram]https://www.instagram.com/360_visibility/ www.360visibility.comhttps://www.360visibility.com/?utm_source=email-signature My working hours may not be your working hours. Please do not feel obligated to reply outside of your normal work schedule. [https://360emailsignatures.blob.core.windows.net/pictures/email-signature-banner.jpg]https://www.360visibility.com/email-signature-banner/?utm_source=email-signature

From: Jesper Schulz-Wedde @.> Sent: Tuesday, December 13, 2022 9:42 PM To: microsoft/ALAppExtensions @.> Cc: Randy Villanueva @.>; Author @.> Subject: Re: [microsoft/ALAppExtensions] [Event Request] Codeunit 6500 - Procedure RetrieveInvoiceSpecification (Issue #20511)

External Email

I can see the changes in the 22 release: [image]https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F19796701%2F207339939-b9d052e5-ff1a-47ae-b4ea-00d9066d7ed7.png&data=05%7C01%7Crvillanueva%40360visibility.com%7C9d90b7f7d4804348f7fe08dadd0fc4cc%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638065357076139996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9F4lc4Al8K09JeG6nzS6AZlnEQCjeFMEoNhMMP7ZSOE%3D&reserved=0

I cannot find them in 21.x yet. @AlexanderYakuninhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAlexanderYakunin&data=05%7C01%7Crvillanueva%40360visibility.com%7C9d90b7f7d4804348f7fe08dadd0fc4cc%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638065357076139996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4roYs0xQBFgn7lp%2B3oJYlKz615TAeQZ7SrKfHUyWFzs%3D&reserved=0, do you have an update on when this event is going to get backported?

- Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FALAppExtensions%2Fissues%2F20511%23issuecomment-1348588020&data=05%7C01%7Crvillanueva%40360visibility.com%7C9d90b7f7d4804348f7fe08dadd0fc4cc%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638065357076139996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iAnhw4QFwS7v0wknsvve3tvJInrcI%2FEXP0WJhrBWorQ%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA3LOYGOMUIP7DX4HYY75DNLWNB4JLANCNFSM6AAAAAAQZ2SRKQ&data=05%7C01%7Crvillanueva%40360visibility.com%7C9d90b7f7d4804348f7fe08dadd0fc4cc%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638065357076139996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m8QY7IKP9Zc0kU8wmq5MAiowBjCyh0N4vLmoTnkY%2F7w%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

Confidentiality Warning: This message and any attachments are intended only for the use of the intended recipient(s), are confidential, and may be privileged. If you are not the intended recipient, you are hereby notified that any review, retransmission, conversion to hard copy, copying, circulation or other use of this message and any attachments is strictly prohibited. If you are not the intended recipient, please notify the sender immediately by return e-mail, and delete this message and any attachments from your system. Thank you Please consider the environment before printing this email.

rvillanueva360 commented 1 year ago

Hi

Our client has been delayed in upgrading from NAV to BC due to these missing events. Waiting until version 22 will mean they will not upgrade as their timeframe to complete the production upgrade is February. If that date is missed they will need to delay for close a year, incurring both BC costs as well as the cost to host their NAV environment.

Can these be expedited in any way?

Thanks Barb

[360 Visibility]https://www.360visibility.com/?utm_source=email-signature Barbara Allen Vice President, Client Solutions @.**@.> | (905) 907-3604<tel:(905)%20907-3604> 926 Nashville Rd., Vaughan ON L0J 1C0 [Twitter]https://twitter.com/360visibility[LinkedIn]https://www.linkedin.com/company/360-visibility[YouTube]https://www.youtube.com/user/360visibilityinc[Facebook]https://www.facebook.com/360Vis/[Instagram]https://www.instagram.com/360_visibility/ www.360visibility.comhttps://www.360visibility.com/?utm_source=email-signature My working hours may not be your working hours. Please do not feel obligated to reply outside of your normal work schedule. [https://360emailsignatures.blob.core.windows.net/pictures/email-signature-banner.jpg]https://www.360visibility.com/email-signature-banner/?utm_source=email-signature

From: Randy Villanueva @.> Sent: December 14, 2022 9:11 AM To: microsoft/ALAppExtensions @.>; microsoft/ALAppExtensions @.> Cc: Author @.>; Barbara Allen @.***> Subject: RE: [microsoft/ALAppExtensions] [Event Request] Codeunit 6500 - Procedure RetrieveInvoiceSpecification (Issue #20511)

Hi Jesper,

Is there a way to expedite these event requests on BC21.x? https://github.com/microsoft/ALAppExtensions/issues/20511 https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FALAppExtensions%2Fissues%2F20511&data=05%7C01%7Cballen%40360visibility.com%7C508e25c1889d4f6cf6e008dadddcf62b%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066238375320482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C7000%7C%7C%7C&sdata=Ju8xI3kJXqAHgfihb%2FY%2BErRUQpThc579PKE5hMvEM0I%3D&reserved=0 https://github.com/microsoft/ALAppExtensions/issues/20512 https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FALAppExtensions%2Fissues%2F20512&data=05%7C01%7Cballen%40360visibility.com%7C508e25c1889d4f6cf6e008dadddcf62b%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066238375320482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C7000%7C%7C%7C&sdata=Cd2rQvuSC2prGIXuaF7bIbtmF7Cj9Nh8AnuBdtPohGo%3D&reserved=0

It is holding up our upgrade project.

Cheers,

From: Jesper Schulz-Wedde @.**@.>> Sent: Tuesday, December 13, 2022 9:42 PM To: microsoft/ALAppExtensions @.**@.>> Cc: Randy Villanueva @.**@.>>; Author @.**@.>> Subject: Re: [microsoft/ALAppExtensions] [Event Request] Codeunit 6500 - Procedure RetrieveInvoiceSpecification (Issue #20511)

External Email

I can see the changes in the 22 release: [image]https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F19796701%2F207339939-b9d052e5-ff1a-47ae-b4ea-00d9066d7ed7.png&data=05%7C01%7Cballen%40360visibility.com%7C508e25c1889d4f6cf6e008dadddcf62b%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066238375320482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C7000%7C%7C%7C&sdata=yiT7FgdR%2FVHNmViuMGK41Gfp8KWsjoDruLHQxk76xAg%3D&reserved=0

I cannot find them in 21.x yet. @AlexanderYakuninhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAlexanderYakunin&data=05%7C01%7Cballen%40360visibility.com%7C508e25c1889d4f6cf6e008dadddcf62b%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066238375320482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C7000%7C%7C%7C&sdata=HZGLzQJ3msmf7HNZK4DfA%2FeRd3jFOnHxahVXTAPtLKE%3D&reserved=0, do you have an update on when this event is going to get backported?

- Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FALAppExtensions%2Fissues%2F20511%23issuecomment-1348588020&data=05%7C01%7Cballen%40360visibility.com%7C508e25c1889d4f6cf6e008dadddcf62b%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066238375320482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C7000%7C%7C%7C&sdata=le20ZfXhOFyuO%2FVKXfM%2FvA6LcdADZjHkEiLMHhpay48%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA3LOYGOMUIP7DX4HYY75DNLWNB4JLANCNFSM6AAAAAAQZ2SRKQ&data=05%7C01%7Cballen%40360visibility.com%7C508e25c1889d4f6cf6e008dadddcf62b%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066238375320482%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C7000%7C%7C%7C&sdata=1C3hEuC%2FvfgIbbDl1C5xSr24%2BcAqnaSmaxZ0p0R3Uqc%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

Confidentiality Warning: This message and any attachments are intended only for the use of the intended recipient(s), are confidential, and may be privileged. If you are not the intended recipient, you are hereby notified that any review, retransmission, conversion to hard copy, copying, circulation or other use of this message and any attachments is strictly prohibited. If you are not the intended recipient, please notify the sender immediately by return e-mail, and delete this message and any attachments from your system. Thank you Please consider the environment before printing this email.

JesperSchulz commented 1 year ago

The merge to 21.x was completed 2 hours ago 🥳 The changes will release with 21.3.

rvillanueva360 commented 1 year ago

Thanks Jesper.

Were you able to cover this as well? https://github.com/microsoft/ALAppExtensions/issues/20512

Cheers,

[360 Visibility]https://www.360visibility.com/?utm_source=email-signature Randy Villanueva Sr. Dynamics Consultant @.**@.> | (905) 907-3610<tel:(905)%20907-3610> 926 Nashville Rd., Vaughan ON L0J 1C0 [Twitter]https://twitter.com/360visibility[LinkedIn]https://www.linkedin.com/company/360-visibility[YouTube]https://www.youtube.com/user/360visibilityinc[Facebook]https://www.facebook.com/360Vis/[Instagram]https://www.instagram.com/360_visibility/ www.360visibility.comhttps://www.360visibility.com/?utm_source=email-signature My working hours may not be your working hours. Please do not feel obligated to reply outside of your normal work schedule. [https://360emailsignatures.blob.core.windows.net/pictures/email-signature-banner.jpg]https://www.360visibility.com/email-signature-banner/?utm_source=email-signature

From: Jesper Schulz-Wedde @.> Sent: Wednesday, December 14, 2022 11:57 PM To: microsoft/ALAppExtensions @.> Cc: Randy Villanueva @.>; Author @.> Subject: Re: [microsoft/ALAppExtensions] [Event Request] Codeunit 6500 - Procedure RetrieveInvoiceSpecification (Issue #20511)

External Email

The merge to 21.x was completed 2 hours ago 🥳 The changes will release with 21.3.

— Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FALAppExtensions%2Fissues%2F20511%23issuecomment-1351682959&data=05%7C01%7Crvillanueva%40360visibility.com%7Cef9f3abc20c8479c283008daddebc97a%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066302052345269%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uyzrufOQ5icdb0s0yHO0qNm5cRQVYgfSFbkUNzTU%2FRo%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA3LOYGKOOEURP655GAINR53WNHU3NANCNFSM6AAAAAAQZ2SRKQ&data=05%7C01%7Crvillanueva%40360visibility.com%7Cef9f3abc20c8479c283008daddebc97a%7C0815a0a621fd4467a0ad296bc115d5f2%7C0%7C0%7C638066302052345269%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rI1at7pRlAQgjoSkPOyWYF1ummVOXa%2FkCaJngc%2F3yrU%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

Confidentiality Warning: This message and any attachments are intended only for the use of the intended recipient(s), are confidential, and may be privileged. If you are not the intended recipient, you are hereby notified that any review, retransmission, conversion to hard copy, copying, circulation or other use of this message and any attachments is strictly prohibited. If you are not the intended recipient, please notify the sender immediately by return e-mail, and delete this message and any attachments from your system. Thank you Please consider the environment before printing this email.

JesperSchulz commented 1 year ago

That one will ship with 21.3 as well, yes.

microsoft / ALAppExtensions

[Event Request] Codeunit 6500 - Procedure RetrieveInvoiceSpecification #20511