microsoft / ALAppExtensions

Repository for collaboration on Microsoft AL application add-on and localization extensions for Microsoft Dynamics 365 Business Central.
MIT License
773 stars 610 forks source link

[Events Request] at 130454 Test Runner - Mgt Codeunit #24894

Closed JerryTyssen closed 5 days ago

JerryTyssen commented 1 year ago

Hello! We are requesting the implementation of 2 new events at 130454 Test Runner - Mgt:

1. Procedure GetTestCodeunit()

local procedure GetTestCodeunit(var CodeunitTestMethodLineFunction: Record "Test Method Line"; TestSuite: Code[10]; TestCodeunit: Integer): Boolean var TestMethodLineImpl: Codeunit TestMethodLineImpl; begin

2. Procedure GetTestFunction()

local procedure GetTestFunction(var TestMethodLineFunction: Record "Test Method Line"; FunctionName: Text[128]; TestSuite: Code[10]; TestCodeunit: Integer; LineNoTestFilter: Text): Boolean var TestMethodLineImpl: Codeunit TestMethodLineImpl; begin TestMethodLineFunction.Reset();

And the at the end of the codeunit:

[IntegrationEvent(false, false)] local procedure OnBeforeGetTestCodeunit(var TestMethodLine: Record "Test Method Line") begin end;

[IntegrationEvent(false, false)] local procedure OnBeforeGetTestFunction(var TestMethodLine: Record "Test Method Line") begin end;

Note: we don't need the IsHandled pattern, but can be added if needed.

Background: we added an internal test case id field in the table "Test Method Line" which we need to filter on in the 2 procedures above.

Thanks in advance,

Jerry Tyssen Cegeka

JesperSchulz commented 5 months ago

Hi @JerryTyssen,

this issue somehow fell through the cracks! Is your event request still valid?

JerryTyssen commented 5 months ago

Hi Jesper,

Yes, it is still valid. The project I was working got postponed, but I still need the requested events.

JerryTyssen commented 1 month ago

@JesperSchulz: Hi Jesper, can you give an update on this event request? When can I expect it? Thanks!

JesperSchulz commented 1 month ago

@JesperSchulz: Hi Jesper, can you give an update on this event request? When can I expect it? Thanks!

I'll ask about the status and push for a fix in version 25. @Aleyenda, is that possible?

nikolakukrika commented 1 month ago

@JesperSchulz: Hi Jesper, can you give an update on this event request? When can I expect it? Thanks!

The issue with these two events is that they would extend the tool in a way that will make it hard for us to move to the managed API in the future. The overall goal is that these codeunits should eventually be moved to the platform, and we do not want extensibility in them that is nice to have.

From our point of view the keys on the test method line are unique. Why you cannot use the keys that we have? What is different in your own solution that makes these events needed?

nikolakukrika commented 5 days ago

Closing as not planned due to lack of feedback. Please reactivate with the answers to the question above.