search

microsoft / ALAppExtensions

Repository for collaboration on Microsoft AL application add-on and localization extensions for Microsoft Dynamics 365 Business Central.
MIT License
769 stars 611 forks source link

[Bug]: Issue while calculating balance in trial balance excel reports. #26580

Closed arvindbinarystream closed 2 months ago

arvindbinarystream commented 3 months ago

Describe the issue

In new excel reports that business central added with v24 in "Dynamics BC Excel Reports" extension seems to have some bugs. 1) report 4405 "EXR Trial Balance Excel" image To calculate correct value of "Net Change", "Balance at Date", "Additional-Currency Net Change", "Add.-Currency Balance at Date" for a G/L Account record, filters must be set to flow filters fields "Global Dimension 1 Filter" and "Global Dimension 2 Filter" of G/L Account record. image

Same issue happens in report 4406 "EXR Trial BalanceBudgetExcel" and report 4408 "EXR Trial Bal by Period Excel".

Expected behavior

"Trial balance Excel (Preview)" report should calculate correct netchange , Balance values for all chart of account with Dimension combinations.

Result in Business central: For chart of account 14130 for Dimension Combination Dimension1Code: '' and Dimension2Code:'' image

Result in Business central: For chart of account 14130 for Dimension Combination Dimension1Code: '000' and Dimension2Code:'LARGE' image

Steps to reproduce

Run report "Trial Balance Excel (Preview)". Once excel file is downloads, open and verify TrialBalanceData sheet in excel file. For example, I have uploaded my result from my data here. Result in report: For chart of account 14130, NetChange and Balance values are exactly same for all dimension combinations.

image

Additional context

No response

I will provide a fix for a bug

JesperSchulz commented 3 months ago

You might be on to something here, but since the code you are referring to is in the BaseApp, you'd have to suggest and fix this code in the BaseApp contribution pilot: https://github.com/microsoft/businesscentralapps. For access to the pilot, please fill out the following form: https://forms.office.com/r/E9wyE5a58f.

This repository is only for extensibility requests or pull requests towards the 1st party Business Central apps.

Would you like me to move the issue to the contribution pilot for you?

IMPORTANT: Microsoft is not going to address the reported issue for you. You will have to get the issue approved, and then push a pull request with the suggested changes yourself. If you would like Microsoft to address the issue, please create a support request.

arvindbinarystream commented 3 months ago

@JesperSchulz thanks for your response. It seems that the change I am requesting is not in the Base App but in the "Dynamics BC Excel Reports" extension. Please guide me how can I request for this extension.

JesperSchulz commented 3 months ago

Ah, sorry, I thought report 4405 was in the BaseApp, but my query was wrong. The report is of course in the "Dynamics BC Excel Reports" app, which is a 1st party app. That app is in this repository, so all good 😊. Based on that, I approve this issue.

arvindbinarystream commented 3 months ago

@JesperSchulz , thanks for the response. Should I create a PR for the above issue?

JesperSchulz commented 2 months ago

You are most welcome to do so!

arvindbinarystream commented 2 months ago

@JesperSchulz Thanks for your response. Looking at the latest code in this repository it seems that correct logic is implemented now. So, the issue I mentioned above will be resolved and I don't need to create a PR for anymore.

mynjj commented 2 months ago

Closing, the bug has been implemented and it will be shipped in a future release.