microsoft / ALAppExtensions

Repository for collaboration on Microsoft AL application add-on and localization extensions for Microsoft Dynamics 365 Business Central.
MIT License
749 stars 599 forks source link

[BC Idea]: Shopify: Save and expose Product Creation Errors #26610

Open eivindgiske opened 1 month ago

eivindgiske commented 1 month ago

BC Idea Link

https://experience.dynamics.com/ideas/idea/?ideaid=9f0096c1-f9c4-ee11-92bd-000d3a058698

Description

At the moment, the Shopify Connector for Dynamics 365 Business Central does not have error handling on Product Sync (Creation in BC). As an end user, BC Items may not be created, and the error message is only available using VS Code debugger.

The Shopify Products page should have an Error Message field, like Shopify Orders, so that users are able to handle errors in product creation without being dependent on BC Developers.

The hidden error message is stored in variable ErrMsg: Text in codeunit 30185 "Shpfy Sync Products"

I will provide the implementation for this BC Idea

JesperSchulz commented 4 weeks ago

@AndreiPanko / @onbuyuka, could you triage this idea, please?

AndreiPanko commented 4 weeks ago

@eivindgiske I understand your scenario is about converting imported Shopify Product to Item in Business Central. We haven't heard any feedback about that (except number series to run out of numbers). Would be interesting to learn where do you see errors?

Also there is no action to create item from product (variant), only mapping. So once user sees the error and solves the underlying bloker (changes no series), what is the action for them to take?

eivindgiske commented 4 weeks ago

Hi @AndreiPanko.

We have implented BC onto an existing Shopify environment, and have used a setup where Shopify (and PIM) are Master for Product information.

Using this setup in BC Shopify Shop, the following business logic will execute.

Report "Shpfy Sync Products" will execute Codeunit "Shpfy Product Import"_ which in turn will evaluate whether an item exists or not, and execute Codeunit "Shpfy Create Item" if an item is unknown to BC. You are correct, there is no Action on the Page Shopify Products to do this manually, but it runs on the product sync.

There are integration events on Codeunit "Shpfy Create Item" that we use to control other aspects of product information. Things might fail for a number of reasons other than No. Series.

I cannot see why a partial error handling has been implemented, but is not stored on the Shopify Products record, and we urgently need this in place.

AndreiPanko commented 4 weeks ago

There are integration events on Codeunit "Shpfy Create Item" that we use to control other aspects of product information. Things might fail for a number of reasons other than No. Series.

Good point about extensibility. @JesperSchulz what are the next steps?

JesperSchulz commented 3 weeks ago

We approve this issue and wait for a PR 🙂