search

microsoft / ALAppExtensions

Repository for collaboration on Microsoft AL application add-on and localization extensions for Microsoft Dynamics 365 Business Central.
MIT License
773 stars 610 forks source link

[Shopify] Connector - Different shipping charges types #26708

Closed aidasberesinevicius closed 2 months ago

aidasberesinevicius commented 3 months ago

This pull request does not have a related issue as it's part of delivery for development agreed directly with @AndreiPanko

Quick summary:

The Shopify Shipping Method Mapping page/table was extended to include a new Shipping Charges Type field, allowing users to select from GL, Item, or Item Charge. Depending on this selection, the Shipping Charges No. field opens the related table (item, GL, or item charges), and when an order is created, the shipping charge line reflects the new type and number. For Item Charges, a default allocation process is run for all item lines. The settings in the Shopify Shipping Method Mapping now take priority over those in the Shopify Shop - GL Account settings. Additionally, if the Shipping Agent Code and Shipping Agent Service fields are populated, they are automatically populated in the sales order as well.

Fixes #26819 AB#449477

pri-kise commented 3 months ago

I know that most developers don't like to be bothered by ToolTips, but wouldn't it be useful to mention the new setup on the charging type in the Shpy Shop Card. https://github.com/microsoft/ALAppExtensions/blob/1cd5eb1074af68706c31a5b9208b0ee84c46d81c/Apps/W1/Shopify/app/src/Base/Pages/ShpfyShopCard.Page.al#L459

And maybe vice versa -when the value isn't specified add an additonal sentence to explain the user that the field of the shpy Shop is used as fallback?

aidasberesinevicius commented 2 months ago

@microsoft-github-policy-service agree company="Companial"