microsoft / ALAppExtensions

Repository for collaboration on Microsoft AL application add-on and localization extensions for Microsoft Dynamics 365 Business Central.
MIT License
768 stars 610 forks source link

[Bug]: Duplicated query on codeunit "Copy Document Mgt.", function CopySalesShptLinesToDoc #26954

Open GiangLNT56 opened 1 month ago

GiangLNT56 commented 1 month ago

Describe the issue

Hi team,

In Codeunit "Copy Document", function CopySalesShptLinesToDoc, I see 2 lines testing "Price Including VAT" as below.

2024-08-05_17h07_36

Expected behavior

I think we should remove the second line.

Steps to reproduce

N/A

Additional context

No response

I will provide a fix for a bug

JesperSchulz commented 2 weeks ago

Sounds fair, but since the code you are referring to is in the BaseApp, you'd have to suggest and fix this code in the BaseApp contribution pilot: https://github.com/microsoft/businesscentralapps. For access to the pilot, please fill out the following form: https://forms.office.com/r/E9wyE5a58f.

This repository is only for extensibility requests or pull requests towards the 1st party Business Central apps.

Would you like me to move the issue to the contribution pilot for you?

IMPORTANT: Microsoft is not going to address the reported issue for you. You will have to get the issue approved, and then push a pull request with the suggested changes yourself. If you would like Microsoft to address the issue, please create a support request. Learn more about our support channels here: https://aka.ms/bcsupport.