microsoft / ALAppExtensions

Repository for collaboration on Microsoft AL application add-on and localization extensions for Microsoft Dynamics 365 Business Central.
MIT License
791 stars 622 forks source link

[BC Idea]: Enable connector with Tietoevry for E-Documents #27057

Open JesperSchulz opened 3 months ago

JesperSchulz commented 3 months ago

BC Idea Link

https://experience.dynamics.com/ideas/idea/?ideaid=a78a8d27-ed2c-ef11-840a-6045bddca9de

Description

It will be good to have connector with Tietoevry service in E-Documents framework, so it will offer more electronic invoicing services as a choice for users.

I will provide the implementation for this BC Idea

Roglar01 commented 2 months ago

How can I assign this issue to me?

JesperSchulz commented 2 months ago

Done 🚀

Roglar01 commented 2 months ago

PR commited. As agreed objects are with temporary id's.

Roglar01 commented 1 week ago

New PR https://github.com/microsoft/ALAppExtensions/pull/27626..

Roglar01 commented 1 week ago

@Groenbech96 As agreed, I closed my first PR and created a new base on pulled code from your branch. Now I'm having issues with creating the PR...

Groenbech96 commented 2 days ago

@Roglar01 I pinged @JesperSchulz to help us fix it :)

JesperSchulz commented 2 days ago

@Roglar01, could you explain what issue you're facing? Which error message are you getting? I'd love to help!

Roglar01 commented 2 days ago

Somehow the issue is now linked to the new PR. My current problem is that you keep changing the e-Document Core..

Roglar01 commented 2 days ago

Seems a little hard to get anywhere with this, when you keep changing the core for us creating e-Doc Connectors ;-(

Warning: AL0432 Enum 'E-Document Integration' is marked for removal. Reason: Use sender, receiver and action integration enums instead. Tag: 26.0. Warning: AL0432 Interface 'E-Document Integration' is marked for removal. Reason: This interface is obsolete. Use Send, Receive and "Default Int. Actions" interfaces instead.. Tag: 26.0. Warning: AL0432 Method 'OnAfterInsertImportedEdocument' is marked for removal. Reason: This event is removed. Use new IDocumentReceiver interface instead. Tag: 26.0. Error: AL0185 Table 'Service Participant' is missing Error: AL0185 Table 'Service Participant' is missing Error: AL0185 Table 'Service Participant' is missing Error: AL0185 Table 'Service Participant' is missing Error: AL0118 The name '"Service Participant"' does not exist in the current context. Error: AL0185 Table 'Service Participant' is missing Error: AL0185 Table 'Service Participant' is missing Error: AL0185 Table 'Service Participant' is missing

JesperSchulz commented 2 days ago

The issue is linked to both the abandoned and the new PR - and that should be fine. We can unlink it to the abandoned one, but it's not necessary. Work item validation in your new PR succeeded, so all is good.

For the compilation challenges, I will bring @Groenbech96 back in the discussion, as I'm not involved in the development of e-documents.

Groenbech96 commented 2 days ago

@Roglar01 Lets take the conversation on the PR. Then we dont have multiple places of communication.

You will need to uptake these changes. Other connectors needed them. Unless someone else asks for changes, they should be locked in. Service participant is under the namespace Microsoft.eServices.EDocument.Service.Participant;

So that will fix that build error.