Closed fvet closed 4 years ago
You've got a very valid point here. Changing the scope of a function isn't really a deprecation - it's a partial deprecation. In your case, the warning makes no sense. We should try to find a better way to notify the developers - your suggestion would do the trick, but would require unnecessary code churn from you, which also wouldn't be perfect. We are working on mechanisms to suppress/remove warnings, which do not apply to you. The situation will improve soon :-) But thanks for letting us know! It's good to know, that what we're working on will be useful!
Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.
Trying to remove any remaining CodeCop warning. Following #5003 ...
AL0432 warning
Method 'GetBodyText' is marked for removal. Reason: Function scope will be changed to OnPrem.
Since my extension targets OnPrem only (app.json) this warning seems redundant (I can't disable an individual warning and need to get rid of any warning for my build pipelines to work )...
Wouldn't it be better to simply move / copy the entire GetBodyText procedure / content (including existing Publishers) to a new OnPrem GetBodyTextFromMemory function instead and replace with