microsoft / ARI

Azure Resource Inventory - It's a Powerful tool to create EXCEL inventory from Azure Resources with low effort
MIT License
1.1k stars 395 forks source link

Not all data present in excel #206

Open BrandonCline85 opened 2 months ago

BrandonCline85 commented 2 months ago

When running versions 3.1.13 and 3.1.38, I'm noticing discrepancies in the output for resources, with some resources not displaying the correct amounts. Is there a workaround for this, or is it a new issue? ARI 8-13-24

Claudio-Merola commented 2 months ago

Hello @BrandonCline85

Looks like something that should be fixed already.

Can you run the version 3.1.38 with -Debug and see how many Jobs run at the same time during the "Processing Inventory" ?

BrandonCline85 commented 2 months ago

Yes, I can run that and paste the output here. It might be tomorrow before I can get to it though.

BrandonCline85 commented 2 months ago

image image image

The output is still showing incorrect numbers for the NSG's and Key Vaults.

Claudio-Merola commented 2 months ago

Hi @BrandonCline85

Thanks for the output. The incorrect numbers are just in the Overview tab or in the Key Vault tab there is indeed only 10 different key vaults?

BrandonCline85 commented 2 months ago

On the NSG's it is showing 13 on the overview, 63 in the tab and the azure portal only has 24

BrandonCline85 commented 2 months ago

Key vaults it shows 10 in the overview, 56 in the tab and there are 13 in the azure portal

Claudio-Merola commented 2 months ago

@BrandonCline85

Yes, because the script will add one line for each "Access Policy" in the Key Vault tab and for NSG it will add one line for each "Security Rule". But the number of unique resources in these tabs are 13 or 24 (for the NSG) and 10 or 13 (for the key vaults)?

BrandonCline85 commented 2 months ago

Correct.

Claudio-Merola commented 2 months ago

Hello, I just released the version 3.5. and since we changed a lot of how the script works (it's no longer a script, but a Powershell Module) and we completely remove the need of az cli as we changed 100% to powershell. This might have changed the previous behavior.

Do you mind and give a try to new version so we can validate if this issue is fixed?

Thanks

BrandonCline85 commented 2 months ago

Thanks for the update. I’m off work today but I will check tomorrow and let you know.

Get Outlook for iOShttps://aka.ms/o0ukef


From: Claudio Merola @.> Sent: Monday, September 2, 2024 1:17:08 PM To: microsoft/ARI @.> Cc: BrandonCline85 @.>; Mention @.> Subject: Re: [microsoft/ARI] Not all data present in excel (Issue #206)

Hello, I just released the version 3.5. and since we changed a lot of how the script works (it's no longer a script, but a Powershell Module) and we completely remove the need of az cli as we changed 100% to powershell. This might have changed the previous behavior.

Do you mind and give a try to new version so we can validate if this issue is fixed?

Thanks

— Reply to this email directly, view it on GitHubhttps://github.com/microsoft/ARI/issues/206#issuecomment-2325173883, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIVFWFBPTNGU4RZPW26AAHTZUSTSJAVCNFSM6AAAAABMO2VU62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGE3TGOBYGM. You are receiving this because you were mentioned.Message ID: @.***>

BrandonCline85 commented 2 months ago

Key Vaults is still showing only 10 items in the spreadsheet and there are 13 currently being used. Azure Firewall is only displaying 1 firewall in the spreadsheet, when there are 2 in place. Please let me know if you need any further info from me. Thanks.

dersteppenwolf commented 1 month ago

Testing with version 3.5: PostgreSQL Flexible appears as 0 but should be 7.

Claudio-Merola commented 1 month ago

@BrandonCline85 , does the missing Key Vaults have Access Policies configured?

@dersteppenwolf, that is just in the Overview or the PostgreeSQL Flexible sheet is also empty?

dersteppenwolf commented 1 month ago

in the Overview or the PostgreeSQL Flexible sheet is also empty?

Both

BrandonCline85 commented 1 month ago

@Claudio-Merola yes there are access policies configured on 10 of them. I'm guessing that is why the other 3 didn't show up in the report.

Claudio-Merola commented 1 month ago

@BrandonCline85 , got it. It should be fixed in the next version (3.5.1). We intend to release it next week.

@dersteppenwolf

Can you check if the resource type of the PostgreeSQL Flexible you have in your environment is: "Microsoft.DBforPostgreSQL/flexibleServers"?

You can check that in the "JSON View" of any your resources.

dersteppenwolf commented 1 month ago

Can you check if the resource type of the PostgreeSQL Flexible you have in your environment is: "Microsoft.DBforPostgreSQL/flexibleServers"?

You can check that in the "JSON View" of any your resources. Looks like this: //Microsoft.DBforPostgreSQL/flexibleServers/

Claudio-Merola commented 1 month ago

@dersteppenwolf

That is strange. Can you run the script adding the "-Debug" parameter and post the output here?

dersteppenwolf commented 1 month ago

@dersteppenwolf

That is strange. Can you run the script adding the "-Debug" parameter and post the output here?

Command:

Invoke-ARI -TenantID xxxx -DiagramFullEnvironment -ReportDir “C:\tmp\AzureResourceInventory\” -QuotaUsage -SecurityCenter -Debug

Some examples from the output:

DEPURACIÓN: 7:50:07 a. m. - GetAzureRmAccessTokenCommand end processing. ConvertFrom-SecureString : No se encuentra ningún parámetro que coincida con el nombre del parámetro 'AsPlainText'. En C:\Program Files\WindowsPowerShell\Modules\AzureResourceInventory\3.5.0\Modules\Inventory\ARIAPIInv.psm1: 17 Carácter: 58 $TokenData = $Token.Token | ConvertFrom-SecureString -AsPlainText CategoryInfo : InvalidArgument: (:) [ConvertFrom-SecureString], ParameterBindingException FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.ConvertFromSecureStringCommand

DEPURACIÓN: 2024-09-05_07_52_26 - Running Module: 'CosmosDB'. Lines Count: 23 DEPURACIÓN: 2024-09-05_07_52_27 - Running Module: 'POSTGREFlexible'. Lines Count: 7

ADVERTENCIA: Algunos nombres de comando importados del módulo 'AzureResourceInventory' incluyen verbos no aprobados que podrían dificultar su reconocimiento. Para encontrar los comandos con verbos no aprobados, vuelva a ejecutar el comando Import-Module con el parámetro Verbose. Para obtener una lista de verbos aprobados, escriba Get-Verb. DEPURACIÓN: 2024-09-05_07_52_53 - Checking if Should Generate Policy Sheet. get-job : El comando no puede encontrar el trabajo porque no se encontró el nombre Policy. Compruebe el valor del parámetro Name e intente ejecutar el comando de nuevo. En C:\Program Files\WindowsPowerShell\Modules\AzureResourceInventory\3.5.0\Modules\Core\ARIExtraJobs.psm1: 261 Carácter: 12 if(get-job -Name 'Policy') CategoryInfo : ObjectNotFound: (Policy:String) [Get-Job], PSArgumentException FullyQualifiedErrorId : JobWithSpecifiedNameNotFound,Microsoft.PowerShell.Commands.GetJobCommand

DEPURACIÓN: 2024-09-05_07_52_53 - Checking if Should Generate Advisory Sheet.

Claudio-Merola commented 1 month ago

@dersteppenwolf

That is odd.

"Running Module: 'POSTGREFlexible'. Lines Count: 7"

This indicate the Postgree Flexible itself was processed correctly and 7 lines should have been added to the Excel file.

The PostgreeSQL Flexible sheet is totally blank and no resources are present? or it has the column titles and there is no resources?

dersteppenwolf commented 1 month ago

The PostgreeSQL Flexible sheet is totally blank and no resources are present? or it has the column titles and there is no resources?

The sheet es totally blank.

Claudio-Merola commented 1 month ago

Hey @dersteppenwolf

I just published the version 3.5.1 of the module and this issue should be fixed. Can you try to upgrade your version of the module and try again?

Thanks

dersteppenwolf commented 1 month ago

Hey @dersteppenwolf

I just published the version 3.5.1 of the module and this issue should be fixed. Can you try to upgrade your version of the module and try again?

Thanks

The command takes too much time and doesn't finish.

Claudio-Merola commented 1 month ago

@dersteppenwolf

Are you running the script with "-Debug" so we can see what the script is doing?

github-actions[bot] commented 2 weeks ago

This Issue is stale and may be automatically close soon.

dersteppenwolf commented 2 weeks ago

The sheet is again totally blank.

Version:

Get-InstalledModule -Name AzureResourceInventory Version Name Repository Description 3.5.7 AzureResourceInventory PSGallery

Command:

Invoke-ARI -TenantID xxx -DiagramFullEnvironment -ReportDir “C:\tmp\AzureResourceInventory\” -QuotaUsage -SecurityCenter -Debug

Log:

DEPURACIÓN: 2024-10-16_20_40_19 - Running Module: 'POSTGREFlexible'. Lines Count: 7