Open paulcam206 opened 2 years ago
@licanhua - are you intending the clang-format change to be enforced in CI? Just asking because we do have a .clang-format
for the shared model.
also, is there a reason to prefer prettier over existing eslint
format enforcement?
yes. There is a good example: Create CI and Ship pipelines by camccaf-msft · Pull Request #7 · microsoft/MixedReality-GraphicsTools-Unreal (github.com)
In short, use Prettier for formatting and linters for catching bugs! Here is the comparision: https://prettier.io/docs/en/comparison.html
makes sense to have a CI job enforce clang-format. I'm not 100% convinced on adding another tool capable of formatting our code to our toolchain, but I'm willing to be convinced :)
@paulcam206 - I believe the X-Plat markdown is out-of-scope for EiM since it is updating production code.
Also - I linked to the C++/WinRT conversion as well
Placeholder issue for work to do during the Engineering Improvements Milestone
#5853