[All] Engineering Improvements 2021

microsoft / AdaptiveCards

A new way for developers to exchange card content in a common and consistent way.

https://adaptivecards.io

MIT License

1.74k stars 543 forks source link

[All] Engineering Improvements 2021 #6632

Open paulcam206 opened 2 years ago

paulcam206 commented 2 years ago

Placeholder issue for work to do during the Engineering Improvements Milestone

[ ] #6481
[x] #6656
[x] #6657
[x] #6658
[ ] #6659
[ ] #6660
[ ] #5911
[ ] #5903
[ ] #5902
[ ] #5884
[ ] ~~#5853~~
[x] #5306
[x] #6323
[ ] #6683
[ ] #5735
[ ] #6694
[ ] #6697
[ ] #6705
[ ] #6708
[x] #6756
[ ] #6762
[ ] #6711
[ ] #6716
[ ] #6731
[ ] #6738
[ ] #6745
[x] #6747
[x] #6749
[ ] #6750
[x] #6789
[ ] #6814

paulcam206 commented 2 years ago

@licanhua - are you intending the clang-format change to be enforced in CI? Just asking because we do have a .clang-format for the shared model.

also, is there a reason to prefer prettier over existing eslint format enforcement?

licanhua commented 2 years ago

yes. There is a good example: Create CI and Ship pipelines by camccaf-msft · Pull Request #7 · microsoft/MixedReality-GraphicsTools-Unreal (github.com)

In short, use Prettier for formatting and linters for catching bugs! Here is the comparision: https://prettier.io/docs/en/comparison.html

paulcam206 commented 2 years ago

makes sense to have a CI job enforce clang-format. I'm not 100% convinced on adding another tool capable of formatting our code to our toolchain, but I'm willing to be convinced :)

jonmill commented 2 years ago

@paulcam206 - I believe the X-Plat markdown is out-of-scope for EiM since it is updating production code.

Also - I linked to the C++/WinRT conversion as well