microsoft / AdaptiveCards

A new way for developers to exchange card content in a common and consistent way.
https://adaptivecards.io
MIT License
1.75k stars 550 forks source link

Investigate why intellisense doesn't work well in designer and warnings in JSON editor with standard examples #6708

Open licanhua opened 2 years ago

licanhua commented 2 years ago

image

paulcam206 commented 2 years ago

as noted in Teams chat, this is because the schema we're handing to monaco is out of date:

https://github.com/microsoft/AdaptiveCards/blob/7bab78696cebcb558d97767d70f1e91eb02f5656/source/nodejs/adaptivecards-designer/src/card-designer.ts#L1019-L1029

we should:

rorik commented 2 years ago

Hey, are there any updates regarding the schema publish change? This doesn't affect just the designer. It's a bit jarring when you open a quickstart sample and get warnings about not following the schema: image

This can be mitigated by changing the schema in the code to https://raw.githubusercontent.com/microsoft/AdaptiveCards/main/schemas/1.4.0/adaptive-card.json or https://raw.githubusercontent.com/microsoft/AdaptiveCards/main/schemas/1.5.0/adaptive-card.json instead of http://adaptivecards.io/schemas/adaptive-card.json.

Not a breaking issue, but it makes getting started to people who have never worked with adaptive cards a little bit harder and to waste time investigating why the documentation does not correspond with what their IDE is saying. Speaking from personal experience.

Thanks!