microsoft / AdaptiveCards

A new way for developers to exchange card content in a common and consistent way.
https://adaptivecards.io
MIT License
1.72k stars 543 forks source link

[Schema Explorer- TextBlock]: Ensure links are distinguished from surrounding text in a way that does not rely on color #8349

Closed vagpt closed 6 months ago

vagpt commented 1 year ago

Target Platforms

Other

SDK Version

1.5

Application Name

Adaptive Cards

Problem Description

Test Environment: URL: https://adaptivecards.io/ OS Version: 22H2 (OS Build 25390.1000) Browser: Edge Dev (111.0.1661.27) Tool: Accessibility Insight for Web

Repro steps:

  1. Open the above URL in the edge dev browser.
  2. Navigate to the 'Text Block' under 'Cards Elements' and press enter key to activate it.
  3. Now, Navigate to the options present under 'text' under properties and run the tool and observe the issue.

Actual Result: Links are not distinguished from surrounding text in a way that does not rely on color.

Expected Result: Ensure links should distinguished from surrounding text in a way that does not rely on color.

Element path: .p > a[href$="ACTextFeatures"][target="_blank"][rel="noopener"]

How to fix: Fix any of the following: The link has insufficient color contrast of 2.97:1 with the surrounding text. (Minimum contrast is 3:1, link text: #0050c7, surrounding text: #000000) The link has no styling (such as underline) to distinguish it from the surrounding text

User Impact: Users with colorblindness and low vision have difficulty in identifying the links present on the page. Users can't be able to differentiate between the normal text and links if links do not have underline/chevron symbols.

WCAG Reference: https://www.w3.org/WAI/WCAG21/Understanding/use-of-color.html

"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “,

Screenshots

MAS1 4 1-Ensure links are distinguished from surrounding text in a way that does not rely on color MAS1 4 1_Ensure links are distinguished from surrounding text in a way that does not rely on color

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

vagpt commented 7 months ago

Hi @anna-dingler,

As this issue is still repro, so could you please let us know is there any future plan to fix this issue?

Snippet:

image

anna-dingler commented 6 months ago

Hi @vagpt,

This issue is fixed on our internal site. I expect us to make another website release this month, so I am marking this as completed.

Please let me know if you have any questions!

vagpt commented 6 months ago

This issue is not repro, hence adding A11yTTValidated tag.