microsoft / AdaptiveCards

A new way for developers to exchange card content in a common and consistent way.
https://adaptivecards.io
MIT License
1.74k stars 543 forks source link

[Adaptive Cards -Publish Adaptive Card Schema]: Ensures <img> elements have alternate text or a role of none or presentation. #8538

Closed vagpt closed 8 months ago

vagpt commented 1 year ago

Target Platforms

Other

SDK Version

1.5

Application Name

Adaptive Cards

Problem Description

Test Environment: OS: Version 23H2 (OS Build 25381.1) URL: https://adaptivecards.io/designer/ Browser: Edge Dev Version 115.0.1880.3 (Official build) dev (64-bit) Tools: Accessibility Insight For Web

Repro Steps:

  1. Open the above URL in the edge dev browser.
  2. Navigate to 'Designer' tab item and press enter key to activate it.
  3. Run accessibility insight for web tool and observe the issue.

Actual Result: elements does not have alternate text or a role of none or presentation as screen reader is announcing only as 'Group'.

Expected Result: Ensures elements should have alternate text or a role of none or presentation.

Element path: .ac-image

Snippet: <img class="ac-image" src="https://pbs.twimg.com/profile_images/3647943215/d7f12830b3c17a5a9e4afcc370e3a37e_400x400.jpeg" style="min-width: 0px; width: 40px; max-height: 100%; border-radius: 50%; background-position: 50% 50%; background-repeat: no-repeat;">

How to fix: Fix any of the following: Element does not have an alt attribute aria-label attribute does not exist or is empty aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty Element has no title attribute Element's default semantics were not overridden with role="none" or role="presentation

User Impact: Users with AT will face difficulty if select element does not have an alt attribute.

WCAG Reference: https://www.w3.org/WAI/WCAG21/Understanding/non-text-content.html

“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)

Screenshots

WCAG_1 1 1-Ensures img elements have alternate text or a role of none or presentation

WCAG1 1 1-Ensures img elements have alternate text or a role of none or presentation

Latest

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

vagpt commented 8 months ago

Hi @anna-dingler,

As this issue is still repro, so could you please let us know is there any future plan to fix this issue?

Snippet:

image

anna-dingler commented 8 months ago

Hi @vagpt,

This issue is fixed on our internal site. I expect us to make another website release this month, so I am marking this as completed.

Please let me know if you have any questions!

vagpt commented 7 months ago

This issue is not repro hence adding A11yTTValidated tag.

image