microsoft / AdaptiveCards

A new way for developers to exchange card content in a common and consistent way.
https://adaptivecards.io
MIT License
1.76k stars 551 forks source link

{Linked:Bug2920242;Linked:Bug2920139} [Adaptive Cards>Designer]: 'You are invited to a swarm session' is not defined as a heading programmatically. #8572

Open vagpt opened 1 year ago

vagpt commented 1 year ago

Target Platforms

Other

SDK Version

1.5

Application Name

Adaptive Cards

Problem Description

Test Environment: URL: https://adaptivecards.io/designer/ OS Version: 23H2{OS Build 25387.1200} Browser Version: Version 116.0.1908.0 (Official build) dev (64-bit) Screen Reader: Narrator

Repro Steps:

  1. Open the above URL in the edge dev browser.
  2. Navigate to the 'Card Payload Editor' expand button and press enter key to activate it.
  3. Paste the below attached JSON.
  4. Navigate to Preview button and press enter key to activate it.
  5. Navigate the opened dialog and observe the issue.

Actual Result: You are invited to a swarm session' is not defined as a heading programmatically. It is defined under paragraph.

Expected Result: You are invited to a swarm session' should be as a heading programmatically and when focus lands on it screen reader should convey the heading level as 1.

User Impact: It will impact the screen reader user as they will not able to understand whether there is a heading or not?

WCAG Reference: Understanding Success Criterion 1.3.1: Info and Relationships | WAI | W3C

Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)

Screenshots

https://github.com/microsoft/AdaptiveCards/assets/95913748/cb5e4e0f-2728-4706-86f0-152d64ac00c0

'You are invited to a swarm session is not defined as heading

Card JSON

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.5",
    "body": [
        {
            "type": "TextBlock",
            "text": "You are invited to a swarm session",
            "wrap": true,
            "weight": "Bolder",
            "size": "Large"
        },
        {
            "type": "RichTextBlock",
            "inlines": [
                {
                    "type": "TextRun",
                    "text": "Mane Koa ",
                    "weight": "Bolder"
                }
            ]
        },
        {
            "type": "TextBlock",
            "text": "Title:",
            "wrap": true,
            "weight": "Bolder"
        },
        {
            "type": "TextBlock",
            "text": "The customer is having trouble installing their air conditioning unit to their power supply",
            "wrap": true
        },
        {
            "type": "TextBlock",
            "text": "Description:",
            "wrap": true,
            "weight": "Bolder"
        },
        {
            "type": "TextBlock",
            "text": "I am having a hard time figuring out what the problem is with this install on the customer air conditioning unit. Here are some of the things we have tried: \n Include details about your case, describe expected and results, include things you've tried",
            "wrap": true
        },
        {
            "type": "TextBlock",
            "text": "You have been asked to join because of these skills: ",
            "wrap": true,
            "weight": "Bolder"
        },
        {
            "type": "TextBlock",
            "text": "Litware, Cafe100",
            "wrap": true
        },
        {
            "type": "ActionSet",
            "actions": [
                {
                    "type": "Action.Submit",
                    "title": "Accept",
                    "data": {
                        "button": "accept"
                    }
                },
                {
                    "type": "Action.Submit",
                    "title": "Reject",
                    "data": {
                        "button": "reject"
                    }
                }
            ]
        }
    ]
}

Sample Code Language

No response

Sample Code

No response

vagpt commented 11 months ago

This bug is originally tracking with using URL below.

https://dev.azure.com/dynamicscrm/OneCRM/_workitems/edit/2920139 https://dev.azure.com/dynamicscrm/OneCRM/_workitems/edit/2920242

Also, changing it from Usable to MAS as per the both linked bugs.