search

microsoft / AdaptiveCards

A new way for developers to exchange card content in a common and consistent way.
https://adaptivecards.io
MIT License
1.75k stars 550 forks source link

[Designer] It seems some properties are not enabled for our designer SDK, #8651

Open Neeraj-swarnkar opened 1 year ago

Neeraj-swarnkar commented 1 year ago

Problem Description

I thought this might be a target version issue, but it's not, It seems some properties are not enabled for our designer SDK,

image image

From Action type -> ToggleVisibility and From Layout -> Vertical content alignment Need to check in detail.

image

I don't see both values in my designer SDK. Kindly help.

Card JSON

NA

Screenshot

No response

@jwoo-msft @anna-dingler Could you please suggest something ?

Neeraj-swarnkar commented 1 year ago

@anna-dingler Can you get some help here, Thanks..

jwoo-msft commented 1 year ago

Hi @Neeraj-swarnkar,

Could you please provide more context regarding what you mean by "our designer"?

Thank you.

Neeraj-swarnkar commented 1 year ago

Hi @Neeraj-swarnkar,

Could you please provide more context regarding what you mean by "our designer"?

Thank you.

Thanks for the reply @jwoo-msft, 'Our Designer' means the code that I have in my local, Recently I have upgraded the designer SDK packages.

options we enabled are below -

ACDesigner.GlobalSettings.enableDataBindingSupport = true; ACDesigner.GlobalSettings.showVersionPicker = true; ACDesigner.GlobalSettings.selectedHostContainerControlsTargetVersion = true; ACDesigner.GlobalSettings.showTargetVersionMismatchWarning = true; ACDesigner.GlobalSettings.supportedTargetVersions = [Adaptive.Versions.v1_0, Adaptive.Versions.v1_1, Adaptive.Versions.v1_2, Adaptive.Versions.v1_3];

From Action type -> ToggleVisibility and From Layout -> Vertical content alignment

Are not visible, should I enable and properties or options.

jwoo-msft commented 1 year ago

c.c @anna-dingler

Neeraj-swarnkar commented 1 year ago

Hi @anna-dingler , can I get your suggestions here ? Please.

anna-dingler commented 1 year ago

Hi @Neeraj-swarnkar,

Have you made any other modifications to your designer package?

The designer initialization for our site can be seen here: https://github.com/microsoft/AdaptiveCards/blob/2bc533d10a946054066999271e13b7bfc3a12f47/source/nodejs/adaptivecards-site/themes/adaptivecards/layout/designer.ejs#L90

I see that you have the ACDesigner.GlobalSettings.selectedHostContainerControlsTargetVersion set to true. I would double check that the host containers you have included are using a high enough version.

Thanks, Anna

Neeraj-swarnkar commented 1 year ago

Hi @Neeraj-swarnkar,

Have you made any other modifications to your designer package?

The designer initialization for our site can be seen here:

https://github.com/microsoft/AdaptiveCards/blob/2bc533d10a946054066999271e13b7bfc3a12f47/source/nodejs/adaptivecards-site/themes/adaptivecards/layout/designer.ejs#L90

I see that you have the ACDesigner.GlobalSettings.selectedHostContainerControlsTargetVersion set to true. I would double check that the host containers you have included are using a high enough version.

Thanks, Anna

Hi @anna-dingler, Thanks for the response,

ACDesigner.GlobalSettings.enableDataBindingSupport = true; ACDesigner.GlobalSettings.showVersionPicker = true; ACDesigner.GlobalSettings.selectedHostContainerControlsTargetVersion = true; ACDesigner.GlobalSettings.showTargetVersionMismatchWarning = true; ACDesigner.GlobalSettings.supportedTargetVersions = [Adaptive.Versions.v1_0, Adaptive.Versions.v1_1, Adaptive.Versions.v1_2, Adaptive.Versions.v1_3];

This is the GlobalSettings we have, In Microsoft designer I checked for every version we have From Action type -> ToggleVisibility and From Layout -> Vertical content alignment

So, it's not the version issue, are we missing any other setting change here ?

anna-dingler commented 3 months ago

Hi @Neeraj-swarnkar,

Are you still running into this issue?