search

microsoft / AirSim

Open source simulator for autonomous vehicles built on Unreal Engine / Unity, from Microsoft AI & Research
https://microsoft.github.io/AirSim/
Other
16.32k stars 4.55k forks source link

Fix image saving in HelloDrone #4658

Open webshared opened 2 years ago

webshared commented 2 years ago

Fixes: #HelloDrone never asked to save image.

About

Fixed HelloDrone/main.cpp code to ask for path and save images. There was a simple bug.

How Has This Been Tested?

Run locally with AirSim, images saved as expected.

Screenshots (if appropriate):

After the fix applied: 

 % ./main 
Waiting for connection - X

Connected!

Client Ver:1 (Min Req:1), Server Ver:1 (Min Req:1)
Press Enter to get FPV image
# of images received: 2
Enter path with ending separator to save images (leave empty for no save)
./img/
Image uint8 size: 62355
Image float size: 0
Image uint8 size: 0
Image float size: 36864
Press Enter to arm the drone
xxEoD2242 commented 2 years ago

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

webshared commented 2 years ago

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

Hey @xxEoD2242, sure pls merge into Colosseum, it has the same issue as I see.

xxEoD2242 commented 2 years ago

Hey @atolkachiov, with the Open Source AirSim project being shutdown, no new features will be integrated. Would you like me to add this to a fork I created to continue development of the open source project? You can find it here: Colosseum (AirSim successor)

Hey @xxEoD2242, sure pls merge into Colosseum, it has the same issue as I see.

Done -> Colosseum PR #2