search

microsoft / Analysis-Services

Git repo for Analysis Services samples and community projects
MIT License
605 stars 416 forks source link

Update diff editor color and fix SHIFT+select feature in ALM toolkit #287

Closed getkeshav closed 3 months ago

getkeshav commented 3 months ago

Updates:

  1. Updated the theme for monaco diff editor's text background.
  2. Resolved the null type issue in the grid component to fix the SHIFT+select feature.

Testing:

  1. Diff editor's theme: image
  2. SHIFT+select feature: image

Anything else I should now?

Please note that the latest monaco diff editor does not change the background color of line numbers of the changed lines. We have verifies this on the monaco editor playground as well. Please refer to the below screenshots:

Older monaco diff editor version:

image

Updated monaco diff editor version:

image

Screenshot from monaco editor playground:

image