microsoft / Analysis-Services

Git repo for Analysis Services samples and community projects
MIT License
605 stars 416 forks source link

Change path trim based on running platform. #293

Open Jtho28 opened 2 months ago

Jtho28 commented 2 months ago

This small change allows pbip publishing to function on unix systems and windows alike without editing the source every time.

Jtho28 commented 2 months ago

@microsoft-github-policy-service agree [company="Kiewit Corporation"] @microsoft-github-policy-service agree @microsoft-github-policy-service agree company="Microsoft"

Jtho28 commented 2 months ago

@microsoft-github-policy-service agree company="Kiewit Corporation"

RuiRomano commented 2 months ago

@Jtho28 looks like 'uname' is not a standard powershell core commandlet.

I'm thinking on doing something like:

$partPath = $filePath.Replace($itemPathAbs, "")

if ($IsWindows) { $partPath = $partPath.TrimStart("\") } else { $partPath = $partPath.TrimStart("/") }

$partPath = $partPath.Replace("\", "/")

Can you please test the above code if it works for your scenario?

Jtho28 commented 2 months ago

@RuiRomano

Yeah this does seem like a more robust solution, I will try it out and test it.

bibinbastian commented 2 months ago

Hi team, any update on this bug?

Jtho28 commented 2 months ago

Hi team, any update on this bug?

Not yet, I've haven't looked at it for awhile. I'm going to test out the proposed solution today on Windows and Unix-like systems.

Jtho28 commented 2 months ago

So I have a tested solution working on Linux, MacOS, and Windows. It's as simple as this, I did get the $IsWindows from @RuiRomano

if ($IsWindows) {
    $partPath = $filePath.Replace($itemPathAbs, "").TrimStart("\").Replace("\", "/")
}
else {
    $partPath = $filePath.Replace($itemPathAbs, "").TrimStart("/")
}