BestPracticeRules/BPARules.json: Rule `PERCENTAGE_FORMATTING` incorrectly formatted

[Julian-J-S]

First of all, thank you for providing nice CI for power bi! I followed this tutorial here: https://learn.microsoft.com/en-us/power-bi/developer/projects/projects-build-pipelines

The CI Rule for PERCENTAGE_FORMATTING could be improved imo

"ID": "PERCENTAGE_FORMATTING",
"Name": "[Formatting] Percentages should be formatted with thousands separators and 1 decimal",
"Category": "Formatting",
"Severity": 2,
"Scope": "Measure",
"Expression": "FormatString.Contains(\"%\") and FormatString <> \"#,0.0%;-#,0.0%;#,0.0%\"",
"FixExpression": "FormatString = \"#,0.0%\\u003B-#,0.0%\\u003B#,0.0%\"",
"CompatibilityLevel": 1200

Problem The expected format has the following problems

• missing the space between the number and the % (correct scientific notation has a space between number and unit)
• deviates from powerbi default %-formatting (which also has the space)

Suggestion

• old: #,0.0%;-#,0.0%;#,0.0%
• new: #,0.0\ %;-#,0.0\ %;#,0.0\ % (uses space ; also power bi default for %)