microsoft / Application-Insights-Workbooks

Templates for Azure Monitor Workbooks
MIT License
562 stars 462 forks source link

Cannot load Deprecated Workbook Retrieval Tool correctly #1562

Closed kozloffj closed 1 year ago

kozloffj commented 3 years ago

Hi! I am trying to run the Deprecated Workbook Retrieval Tool as described here - https://github.com/microsoft/Application-Insights-Workbooks/blob/master/Documentation/LegacyAI/DeprecatedWorkbookRetrievalTool.md.

When I try to load it in a new Workbook, I get an error. After further review, there are unnecessary double quotes in some locations. After I removed the double quotes (Using Visual Studio Code) it loads. After selecting a Subscription and Resource Group though, another section has an error where it says an API parameter must be added and the Subscription path was not passed. I added the subscription path manually and a API, but nothing else loads.

Can you take a look please?

Thank you, Jeff Kozloff

kozloffj commented 3 years ago

Here is the updated JSON with the extra double quotes removed.

UpdatedWorkbookRetrievalTool.txt

darthkurak commented 3 years ago

Have the exactly same problem. I would like to retrieve deprecated workbooks (shared), but scripts doesn't work.

gardnerjr commented 3 years ago

how exactly are you using the files that you're getting errors?

1) open a new empty workbook

2) go into edit mode, and advanced mode

3) open the correct file from github, in raw mode, so you only have the workbook content, for example

4) paste that into advanced mode JSON box in workbooks, 5) press apply

when i do this i see no issues. is there some other set of steps you are doing that gets extra quotes?

kozloffj commented 3 years ago

Hi @gardnerjr ! Thanks for the follow-up. The links you provided just worked. The difference is:

I go to this page in Github - https://github.com/microsoft/Application-Insights-Workbooks/blob/master/Documentation/LegacyAI/DeprecatedWorkbookRetrievalTool.md

I click on Private Workbook Conversion link image

When I do this, I copy the code form that screen and paste it into the editor, I get the following failure -

image

HOWEVER, if I use the Raw links you provided above, I get no error. Not sure why they are different but maybe you can link to the raw links you listed in your reply above instead in the md file and that will help others.

Thanks!

Jeff Kozloff

kozloffj commented 3 years ago

Just to clarify, this is the screen that causes errors in the JSON - image

Need to click on "Raw" button for proper format - image

Hope this helps others!

Thanks! Jeff

gardnerjr commented 3 years ago

yes, the screen that you see in github's normal view is rendering the workbook json as text/markdown, so if you copy/paste from there strange things can happen. you need to go to the raw view explicitly.

gardnerjr commented 3 years ago

@tonykslee can you update the instructions to give the literal instructions (or links?) for the raw files instead of just "(raw)" in parens? see my explicit instructions above that unblocked/clarified here.