search

microsoft / Application-Insights-Workbooks

Templates for Azure Monitor Workbooks
MIT License
562 stars 462 forks source link

HA Alert broken after PR: 2235 #2246

Closed M2skills closed 1 year ago

M2skills commented 1 year ago

HA Alert Template for SapMonitor2.0 is broken after the PR: https://github.com/microsoft/Application-Insights-Workbooks/pull/2235 The above PR payload has already been deployed to PPE.

We want the payload to be stopped from being deployed in MPAC and Prod regions. We have raised a revert PR and merged to main: https://github.com/microsoft/Application-Insights-Workbooks/pull/2244

We need help in deploying the revert to all regions, if this get deployed all the customers will get impacted.

gardnerjr commented 1 year ago

@m2skills how is your team testing this content before completing PRs?

Isn't this the second time (#2210) this specific template has been regressed and required hotfix? Hotfixes are time consuming, expensive, and are not a replacement for testing.

gardnerjr commented 1 year ago

back on the orginal topic, the PPE train was stopped and a newer build took its place, this is technically done. though we have changed the hotfix request instructions to go through ICM instead of here for better tracking and visibility.