microsoft / ApplicationInsights-JS

Microsoft Application Insights SDK for JavaScript
MIT License
650 stars 240 forks source link

[BUG] client_OS doesn't show Windows 11 #1721

Open coreyroth opened 2 years ago

coreyroth commented 2 years ago

I don't know if this is by design of either Windows / Edge and / or the Application Insights SDK. However, I noticed that the client_OS field in pageViews shows Windows 10 instead of Windows 11.

I am guessing the SDK uses either navigator.appVersion, navigator.userAgent, or navigator.userAgentData to determine the value for this column. When examining that string I can see the difficulty. However, I wanted to raise this as I know customers have an interest in seeing the breakdown between Windows 10 and Windows 11.

Steps to Reproduce Log a pageView using the SDK on a Windows 11 device.

Expected behavior client_OS shows Windows 11

MSNev commented 2 years ago

This is also problematic as the chromium UserAgent reported by windows 11 actually identifies as Windows 10. And by default the new secure client headers do not send the OS version. Also on the client the getHighEntrophyValues() API (the only way to get the reported OS version -- which is v14 on Windows 11) is asynchronous, so unless you hold up the PageView event from being reported (which will affect the reported time) this information would also not be included.

github-actions[bot] commented 1 year ago

This Issue will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action.

github-actions[bot] commented 1 year ago

This Issue will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action.

htryggva commented 11 months ago

We would also appreciate the ability to see the distribution of Windows 10 and Windows 11 customers. We are still seeing this issue when using these versions:

github-actions[bot] commented 5 days ago

This Issue will be closed in 30 days. Please remove the "Stale" label or comment to avoid closure with no action.