search

microsoft / ApplicationInsights-Kubernetes

Enrich the telemetry data for .NET applications running inside containers that are managed by Kubernetes.
Other
135 stars 57 forks source link

Compliance: Unit test SDK depends on Newtonsoft.Json 9.0.1 #329

Closed xiaomi7732 closed 1 year ago

xiaomi7732 commented 1 year ago

Dependency graph:

image

It looks like an option is to bump the unit test SDK to 17.4.0-preview-20220707-01 or above, that will carry a version of Newtonsoft.Josn >= 13.0.0

Considering it is unit tests only, the production package doesn't depend on it, another option might be to hold still until there's a newer stable version of the test SDK.

Does anyone see an urgent to upgrade it immediately? There's also an option to directly depend on the latest version of Newtonsoft.Json in the unit test project.

xiaomi7732 commented 1 year ago

Tagging @JacobBovee , @karolz-ms too. Does either of you have any preference?

karolz-ms commented 1 year ago

No strong preference since this is test code. Bumping the test SDK to 17.4+ might be the safest option if you decide to fix it now, as opposed to waiting.