search

microsoft / ApplicationInsights-Kubernetes

Enrich the telemetry data for .NET applications running inside containers that are managed by Kubernetes.
Other
135 stars 57 forks source link

Enhancement: Capture container image name #342

Closed aforank closed 1 year ago

aforank commented 1 year ago

Image name is one of the critical parameters to check when something goes wrong. I know I can get the image name by first referring to a pod Id, then query the cluster and find out the image name. But as you see it is a two way step now to get that tiny information.

Therefore, it would be better to capture the image name along with other telemetry properties.

xiaomi7732 commented 1 year ago

@aforank Thanks for the proposal. I think it makes sense. Do you want to submit a PR for it?

aforank commented 1 year ago

@xiaomi7732 xiaomi7732 Yes, I can submit a PR... You may assign it to me for tracking purposes.

xiaomi7732 commented 1 year ago

Perfect! Looking forward to it.

xiaomi7732 commented 1 year ago

@aforank, your code is released in 6.1.1-beta1 here: https://www.nuget.org/packages/Microsoft.ApplicationInsights.Kubernetes/6.1.1-beta1

Please check it out and let us know.

aforank commented 1 year ago

@xiaomi7732 Thanks. I tried it today and it is working as expected.

xiaomi7732 commented 1 year ago

@aforank, you are welcome! I'll close this issue for now. Feel free to file new ones.