search

microsoft / ApplicationInsights-PHP

Azure Application Insights SDK for PHP
https://azure.microsoft.com/services/application-insights/
Other
108 stars 92 forks source link

Set message severity level in trackMessage on TelemetryClient #28

Closed Peter-Juhasz closed 7 years ago

Peter-Juhasz commented 7 years ago

The ability to set severity level already exists on Message_Data contract.

msftclas commented 7 years ago

@Peter-Juhasz, Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request. Thanks, Microsoft Pull Request Bot

JakubOleksy commented 7 years ago

Can you add/modify a unit test to test the new property?

Peter-Juhasz commented 7 years ago

Yes, sorry, I just didn't have the infrastructure to run PHP unit tests.

We are lifting a few PHP applications to Azure Web Apps and trying to utilize its full power by collecting rich telemetry data. These changes were simple and I wanted to share them so other people can benefit too and speed up the development of this library a little bit.

JakubOleksy commented 7 years ago

Thanks!

msftclas commented 7 years ago

@Peter-Juhasz, Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request. Thanks, Microsoft Pull Request Bot