search

microsoft / ApplicationInsights-PHP

Azure Application Insights SDK for PHP
https://azure.microsoft.com/services/application-insights/
Other
108 stars 92 forks source link

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #36

Closed carusogabriel closed 6 years ago

carusogabriel commented 7 years ago

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

Also, set the minimum version of PHPUnit for 4.8.36, that contains these namespaces support.

msftclas commented 7 years ago

CLA assistant check
All CLA requirements met.

wilsonge commented 7 years ago

You need to bump the minimum PHPUnit version if you want to do this. That class has only existed since PHP 5.4.3 https://github.com/sebastianbergmann/phpunit/blob/aa47f767c5ecadab9df0862c34398e4ee582bb56/ChangeLog-5.4.md#543---2016-06-09

carusogabriel commented 7 years ago

@wilsonge Actually, was 4.8.36. But thanks for the advise, I'll require it.

JakubOleksy commented 6 years ago

Can you review the conflicts?

carusogabriel commented 6 years ago

@JakubOleksy Done :+1: