Remove dependency on Newtonsoft.Json - i2

microsoft / ApplicationInsights-Profiler-AspNetCore

Application Insights Profiler sample and documentation

MIT License

66 stars 23 forks source link

Remove dependency on Newtonsoft.Json - i2 #163

Closed xiaomi7732 closed 2 years ago

xiaomi7732 commented 2 years ago

[ ] Bump up the dependency to microsoft.applicationinsights.windowsserver.telemetrychannel to 2.15 +
[ ] Update the code in ConfigureUserConfiguration.cs as well as ServiceProfilerStartupFilter.cs.
[ ] Convert other places that still uses Newtonsoft.Json for serialization.

For testing, please bump up MS.ApplicationInsights.AspNetCore to 15.0+ to avoid bringing in Newtonsoft.Json on the dependency tree.

pjquirk commented 2 years ago

Does this include the Newtonsoft.Json.Schema library as well? It's license is AGPL-3.0-only, which is currently problematic for us since it's unclear we can use it directly.

xiaomi7732 commented 2 years ago

@pjquirk Thanks for the ask. @JacobBovee , could you please answer that?

JacobBovee commented 2 years ago

Hey @pjquirk yep this includes Newtonsoft.Json.Schema. The next package release will include this change and we should be getting that out really soon.

xiaomi7732 commented 2 years ago

Released: https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.AspNetCore/2.4.0-beta1