search

microsoft / ApplicationInsights-Profiler-AspNetCore

Application Insights Profiler sample and documentation
MIT License
66 stars 22 forks source link

Null exception in Settings Contract when settings do not exist. #174

Closed JacobBovee closed 2 years ago

JacobBovee commented 2 years ago

Refer to #172 for more info. Currently when remote settings do not exist they are deserialized as null breaking parsing and throwing an exception. This should not break profiling.

xiaomi7732 commented 2 years ago

Hey @JacobBovee , do you mind also double check, for users that don't have profiler settings on our backend, are policies like OnDemand working?

I have a hypothesis that when there's no settings, the profiler might just not working - b/c everything would be treated as disabled and it overwrites the local settings.

JacobBovee commented 2 years ago

This is resolved in the new stable release (2.4.0)