search

microsoft / ApplicationInsights-SDK-Labs

Application Insights experimental projects repository
MIT License
61 stars 48 forks source link

Add extension method for Request telemetry #10

Closed tomasr closed 8 years ago

tomasr commented 8 years ago

... to match the corresponding method in the Web SDK.

Also increment the version number and publishing date to resolve build errors.

SergeyKanzhelev commented 8 years ago

Hi @tomasr

Got error in build, can you pls fix it?

F:\A_work\22\obj\Release\DependencyCallstacks\Net45\AssemblyInfo.g.cs (14, 28)

The specified version string does not conform to the required format - major[.minor[.build[.revision]]]

F:\A_work\22\obj\Release\DependencyCallstacks\Net45\AssemblyInfo.g.cs (15, 32)

The specified version string does not conform to the recommended format - major.minor.build.revision

F:\A_work\22\obj\Release\DependencyCallstacks\Net40\AssemblyInfo.g.cs (14, 28)

The specified version string does not conform to the required format - major[.minor[.build[.revision]]]

F:\A_work\22\obj\Release\DependencyCallstacks\Net40\AssemblyInfo.g.cs (15, 32)

The specified version string does not conform to the recommended format - major.minor.build.revision

Process 'msbuild.exe' exited with code '1'.

tomasr commented 8 years ago

I was getting the same error previously because the SemanticVersionDate in Version.props was too old; I updated it and the error went away. Have you tried doing a Rebuild All?

SergeyKanzhelev commented 8 years ago

hm, it is happening on build machine... Maybe AssemblyInfo.g.cs not being cleaned up.

@abaranch, @madeleinefletcher - I remember something similar was happening on SDK repository. Do you remember the root cause/remediation?

tomasr commented 8 years ago

Looks like the problem is just that the AssemblyInfo.g.cs isn't getting regenerated on each build:

Skipping target "GenerateAdditionalSources" because all output files are up-to-date with respect to the input files.

Should the build server be doing a Clean;Build rather than just running the Build target?

More details Because the <SemanticVersionDate> property is fairly old in the DependencyCallstacks and AggregateMetrics projects is so old, they can end up failing due to the <PreReleaseVersion> field generating large values for the AssemblyVersion attribute.

I noticed that all projects here are dividing the number of hours by 5, while the main SDK ones are dividing by 6, so that probably helps. Should we update both?

Also, I believe dirs.proj should be importing Globals.props. Otherwise, doing a clean on it will end up attempting to clean \, because BinRoot and Configuration won't be defined (which actually happened to me last night and wiped half my HDD!).

SergeyKanzhelev commented 8 years ago

Oh, I'm sorry for this. I hope you had a backup.

I'll get to it tomorrow and try to fix the build.