microsoft / ApplicationInsights-ServiceFabric

ApplicationInsights SDK for ServiceFabric projects
MIT License
63 stars 26 forks source link

Fixed actor method tracing by switching over to use IdUtil via reflec… #21

Closed brahmnes closed 7 years ago

brahmnes commented 7 years ago

…tion to get the ids and build a map of our own, rather than relying on the ServiceRemotingDispatcher. The reason is that

it's quite difficult to access the map for the actor. This approach is almost much cleaner, with less reflection calls. Both actor and services on both client and handler sides have switched to use the new MethodNameProvider, which implements this new approach. Removed the base class CorrelatingProxyFactory as it seemed unnecessary after factoring out the method name provider into a separate class.

msftclas commented 7 years ago

@brahmnes, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot