search

microsoft / ApplicationInsights-ServiceFabric

ApplicationInsights SDK for ServiceFabric projects
MIT License
63 stars 26 forks source link

Dependency / Request Tracking and correlation implementation for Service Fabric Service Remoting. #51

Closed nizarq closed 6 years ago

nizarq commented 6 years ago

This changeset contains implementation for two new modules responsible for auto collecting request and dependencies when Service Remoting is used for service communication. The change also encompases correlation using Activity as well as x-component correlation using AppId passed through headers. This change takes advantage of the events I've added in the service remoting stack. As these events are only available for service remoting V2. I've not removed the V1 helper classes from this project. Customers using V1 should continue to use those classes.

wsklorz commented 6 years ago

Guys, when it will be production ready? We really need it for our ServiceFabric new project based on Core 2.0

codellica commented 6 years ago

It seems that this is the only library that stops me to upgrade to new service fabric 6.1.

brahmnes commented 6 years ago

@wsklorz, @codellica Thank you for your comments. We understand this is very much needed. Since this change has a new dependency on the service fabric runtime, we are coordinating with them the release.

wsklorz commented 6 years ago

So as I understand we should downgrade our SF solution if the project is scheduled to be released to Live in two weeks?

brahmnes commented 6 years ago

@wsklorz We are wrapping up our work with Service Fabric on an update to address this. It will be at least a few more weeks. The options are, either hang on and wait, or downgrade for now and upgrade again later. I am sorry that I don't have better options for now.