Using Application Insights with Service Fabric V1 remoting causes request tracking failure

[alexmarshall132]

Version: 2.1.0-beta1

Stack Trace:

System.NullReferenceException:

   at Microsoft.ApplicationInsights.ServiceFabric.Module.RequestTrackingUtils.GetBaggageFromActivity (Microsoft.AI.ServiceFabric.Native, Version=2.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35)

   at Microsoft.ApplicationInsights.ServiceFabric.Remoting.Activities.CorrelatingServiceRemotingClient+<SendAndTrackRequestAsync>d__19.MoveNext (Microsoft.AI.ServiceFabric.Native, Version=2.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35)

Repeatability: Every time, consistently when using V1 remoting with instructions provided in readme.md with Full Framework Stateless service.

[yantang-msft]

@alexmarshall132 I just tried and can't repro the issue you had. Could you share a simple project that repros?

[alexmarshall132]

Hi Yanming,

I'll work on getting you a sample ASAP, it's been a busy week

On Tue, Apr 24, 2018 at 1:14 PM, Yanming Tang notifications@github.com wrote:

@alexmarshall132 https://github.com/alexmarshall132 I just tried and can't repro the issue you had. Could you share a simple project that repros?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microsoft/ApplicationInsights-ServiceFabric/issues/62#issuecomment-384047598, or mute the thread https://github.com/notifications/unsubscribe-auth/ABt6JnvqffEWAMQz7i8s4HJtwWku8w7Nks5tr3mNgaJpZM4Teu4B .

-- Alex

[brahmnes]

Hi Alex,

Which version of Application Insights SDK are you running? Is it 2.3 or 2.4+?

[yantang-msft]

@alexmarshall132 I reproduced the bug. And it's fixed in PR https://github.com/Microsoft/ApplicationInsights-ServiceFabric/pull/72. Before the nuget is released, you can manually upgrade Microsoft.ApplicationInsights nuget to 2.4+ and the problem should go away.

[alexmarshall132]

Thank you very much Yanming. I appreciate it.

On Thu, 31 May 2018, 12:46 PM Yanming Tang notifications@github.com wrote:

Closed #62 https://github.com/Microsoft/ApplicationInsights-ServiceFabric/issues/62 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microsoft/ApplicationInsights-ServiceFabric/issues/62#event-1656704936, or mute the thread https://github.com/notifications/unsubscribe-auth/ABt6JmETk-rNQA1OmKJofaniz1l3Bn13ks5t4DqIgaJpZM4Teu4B .