search

microsoft / ApplicationInsights-aspnetcore

ASP.NET Core web applications monitoring
313 stars 123 forks source link

bump version 2.8.0-beta3 #974

Closed TimothyMothra closed 5 years ago

TimothyMothra commented 5 years ago

also updated DiagnosticSource to stay in sync with WebSDK https://github.com/microsoft/ApplicationInsights-dotnet-server/pull/1252

TimothyMothra commented 5 years ago

Test failed:

MVC20.FuncTests.TelemetryModuleWorkingMvcTests.TestIfPerformanceCountersAreCollected [25ms] Error Message: System.IO.IOException : Failed to bind to address http://127.0.0.1:12226: address already in use.

lmolkova commented 5 years ago

@cijothomas
Didn't we have some tests disabled waiting for DependencyCollector? Should we re-enable them?

cijothomas commented 5 years ago

@lmolkova Yes we need to reenable all ignored tests. [Fact(Skip = "Re-Enable once DependencyTrackingModule is updated to latest DiagnosticSource.")]

TimothyMothra commented 5 years ago

@cijothomas, just to confirm... Do you want to wait until the stable release of DiagnosticSource before enabling ignored tests?

lmolkova commented 5 years ago

@TimothyMothra tests are ready to be enabled now and should pass. This is I believe prereq for beta3. Would you mind enabling them as a part of this PR?

TimothyMothra commented 5 years ago

@lmolkova gladly. i'll take care of it right now :)

cijothomas commented 5 years ago

ready to merge